step-registry: add upgrade workflows #11247
Conversation
|
/cc @wking |
openshift-ci-robot
added
the
approved
ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
Show resolved
Hide resolved
ci-operator/step-registry/ipi/upgrade/aws/ipi-upgrade-aws-workflow.yaml
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/openshift/upgrade/aws/openshift-upgrade-aws-workflow.yaml
Outdated
Show resolved
Hide resolved
stevekuznetsov
force-pushed
the
skuznets/e2e-upgrade
branch
2 times, most recently
from
1162283 to
6487985
Compare
openshift-ci-robot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/e2e-upgrade
branch
from
6487985 to
4731300
Compare
openshift-ci-robot
removed
the
needs-rebase
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/e2e-upgrade
branch
from
4731300 to
eb8eb32
Compare
|
OK I think this is working as expected now |
|
Wish this didn't start thirty rehearsals 😬 |
|
Oh, I see. "real" releases don't have |
The "base" image is present only from CI streams and won't be around for jobs that operate on imported releases, so using a generic CentOS image instead will work for all types of jobs. Signed-off-by: Steve Kuznetsov <[email protected]>
Seems to work! |
|
This looks neat! The "supersedes" link in the description is wrong: I think #9489 is the correct one. |
ci-operator/step-registry/ipi/upgrade/aws/ipi-upgrade-aws-workflow.yaml
Outdated
Show resolved
Hide resolved
|
/uncc |
| @@ -0,0 +1,11 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
Symlink to ../OWNERS? I doubt we will need flavor-specific maintainer sets here, and your current sets look like dups.
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/e2e-upgrade
branch
from
49032d4 to
39be8a9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stevekuznetsov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test all |
|
@stevekuznetsov: Updated the following 5 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As originally done in #11247. `tools` only exists in 4.5+ releases.
Tests generally install one OpenShift release, and then perform some actions to validate that release. Sometimes the actions include updating to a different release, or a series of different releases. With this commit, I'm pivoting to dependency naming that more clearly reflects these goals, instead of "RELEASE_IMAGE_LATEST", which was a reflection of the default release:latest value, and not an expression of the intended semantics. I've shifted to explicitly declaring these image dependencies, taking advantage of openshift/ci-tools@782008c873 (ci-operator: allow users to depend on images in steps, 2020-07-30, openshift/ci-tools#1044), instead of relying on the implicit RELEASE_IMAGE_LATEST and similar. I've dropped explicit dependencies that were not used in a step's associated commands, like RELEASE_IMAGE_LATEST in ipi-install since eb8eb32 (step-registry: add upgrade workflows, 2020-08-25, openshift#11247). I've dropped explicit dependency overrides that set the same value as the default. For example, there was no need to set: OPENSHIFT_UPGRADE_RELEASE_IMAGE: "release:latest" in openshift-upgrade-aws-loki, because release:latest is already the default in all steps that consume OPENSHIFT_UPGRADE_RELEASE_IMAGE. I've dropped the _OVERRIDE suffix from the dependencies, because while we may set that suffix when communicating with the openshift-install command, it's a legitimate knob and not a strange override in each steps' public API.
Signed-off-by: Steve Kuznetsov [email protected]
Supersedes openshift/ci-tools#1136