-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Deploy loki in a new template #10397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77eeaa3
to
4e13664
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ile to ensure they are added to a ConfigMap in the CI cluster
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
88f6bab
to
5d5dbd9
Compare
/hold cancel |
@@ -0,0 +1,2159 @@ | |||
kind: Template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just for testing? How much is duplicated code?
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
@ingvagabund: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before all upgrade jobs get migrated to the new step framework (e.g. #9489), I am temporarily copy pasting the current template from https://github.com/openshift/ci-tools/blob/master/pkg/steps/clusterinstall/template.go and extending it with loki deployed. So it can be used in selected CI upgrade jobs with loki.
Following https://github.com/openshift/release/tree/master/ci-operator#adding-a-template:
With the template file ready, the steps required to add it to the repository and make it available for CI jobs are:
After updating openshift/origin configs:
running
make jobs
ends with:Which is expected I guess based on https://github.com/openshift/release/tree/master/ci-operator#adding-a-template: