Skip to content

Deploy loki in a new template #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jul 22, 2020

Before all upgrade jobs get migrated to the new step framework (e.g. #9489), I am temporarily copy pasting the current template from https://github.com/openshift/ci-tools/blob/master/pkg/steps/clusterinstall/template.go and extending it with loki deployed. So it can be used in selected CI upgrade jobs with loki.

Following https://github.com/openshift/release/tree/master/ci-operator#adding-a-template:

With the template file ready, the steps required to add it to the repository and make it available for CI jobs are:

  1. Create the yaml file in the templates/ directory.
  2. Add the files to the config-updater section of Prow's configuration file to ensure they are added to a ConfigMap in the CI cluster.
  3. Optional: add a test type to ci-operator to enable automatic generation of jobs that use this template.
  4. Add necessary secrets (if any) to the deployment configuration in this repository and apply it to the cluster.

After updating openshift/origin configs:

- as: e2e-gcp-upgrade
  commands: TEST_SUITE=all run-upgrade-tests
  openshift_installer_src_loki:
    cluster_profile: gcp
    upgrade: true

running make jobs ends with:

$ make jobs
docker pull registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest
Trying to pull repository registry.svc.ci.openshift.org/ci/ci-operator-prowgen ... 
sha256:d0b17d321a5b22452946062780440ed7d7f7a875c64e603eb7746a06e64d09ed: Pulling from registry.svc.ci.openshift.org/ci/ci-operator-prowgen
524b0c1e57f8: Already exists 
b1c21205a47f: Pull complete 
Digest: sha256:d0b17d321a5b22452946062780440ed7d7f7a875c64e603eb7746a06e64d09ed
Status: Downloaded newer image for registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest
docker run --rm -v "/home/jchaloup/Projects/src/github.com/openshift/release:/go/src/github.com/openshift/release:z" -e GOPATH=/go registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest --from-release-repo --to-release-repo
time="2020-07-27T12:14:39Z" level=error msg="Failed to load CI Operator configuration" error="invalid ci-operator config: invalid configuration: tests[11] has no type, you may want to specify 'container' for a container based test" source-file=/go/src/github.com/openshift/release/ci-operator/config/openshift/origin/openshift-origin-master.yaml
time="2020-07-27T12:14:39Z" level=fatal msg="Failed to generate jobs" error="invalid ci-operator config: invalid configuration: tests[11] has no type, you may want to specify 'container' for a container based test" source=/go/src/github.com/openshift/release/ci-operator/config subdir= target=/go/src/github.com/openshift/release/ci-operator/jobs
Makefile:46: recipe for target 'jobs' failed
make: *** [jobs] Error 1

Which is expected I guess based on https://github.com/openshift/release/tree/master/ci-operator#adding-a-template:


Because the configuration updater configuration has to be updated before a PR with the files is merged, those changes have to be merged previously in a separate PR.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 22, 2020
@ingvagabund ingvagabund force-pushed the deploy-loki-in-template branch from 77eeaa3 to 4e13664 Compare July 27, 2020 12:06
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
To complete the pull request process, please assign hardys, stevekuznetsov
You can assign the PR to them by writing /assign @hardys @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ile to ensure they are added to a ConfigMap in the CI cluster
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2020

@ingvagabund: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/ComplianceAsCode/content/master/e2e-aws-ocp4-moderate 77eeaa31c15b2485af1ee17824491cb13b76d4b1 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-gcp-upgrade 77eeaa31c15b2485af1ee17824491cb13b76d4b1 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund ingvagabund force-pushed the deploy-loki-in-template branch from 88f6bab to 5d5dbd9 Compare July 27, 2020 12:20
@ingvagabund ingvagabund changed the title wip: Deploy loki in template Deploy loki in template Jul 27, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2020
@ingvagabund ingvagabund changed the title Deploy loki in template Deploy loki in a new template Jul 27, 2020
@ingvagabund
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@@ -0,0 +1,2159 @@
kind: Template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just for testing? How much is duplicated code?

@openshift-merge-robot
Copy link
Contributor

@ingvagabund: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/secret-generator-config-valid 5d5dbd9 link /test secret-generator-config-valid

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

/close

@openshift-ci-robot
Copy link
Contributor

@ingvagabund: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants