Skip to content

maipo: Revert to released content #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

maipo: Revert to released content #315

merged 1 commit into from
Sep 25, 2018

Conversation

cgwalters
Copy link
Member

Per discussion.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2018
@cgwalters cgwalters changed the title maipo: Revert to released comment maipo: Revert to released content Sep 25, 2018
@miabbott
Copy link
Member

Aside: looking at the most recent treecompose, we aren't pulling any packages from the maipo-atomic repo. Could we ditch that repo?

@wking
Copy link
Member

wking commented Sep 25, 2018

This is effectively reverting #286, no? That's fine (assuming the released content has progressed enough to get a working CRI-O / Podman stack in the meantime ;), but I want to make sure I'm understanding what's happening.

@cgwalters
Copy link
Member Author

This is effectively reverting #286, no?

Yes, but #288 followed right after it, which we're retaining.

ashcrow
ashcrow approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me since cri-o, podman, runc, etc.. come from cri-o-tested.

@ashcrow
Copy link
Member

ashcrow commented Sep 25, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2018
@openshift-merge-robot openshift-merge-robot merged commit c334abb into openshift:master Sep 25, 2018
@yuqi-zhang yuqi-zhang mentioned this pull request Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dm0- dm0- Awaiting requested review from dm0-

@sdemos sdemos Awaiting requested review from sdemos

Assignees

@ashcrow ashcrow

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cgwalters @miabbott @wking @ashcrow @yuqi-zhang @openshift-ci-robot @openshift-merge-robot