mcc: add ignition validation to render controller #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/S
kikisdeliveryservice
requested review from
cgwalters
and removed request for
ashcrow
kikisdeliveryservice
changed the title
kikisdeliveryservice
changed the title
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
2 times, most recently
from
0da80a4 to
a7a86b8
Compare
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
from
a7a86b8 to
ec11c95
Compare
openshift-ci-robot
added
size/M
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
4 times, most recently
from
eb3f60f to
9469cd6
Compare
kikisdeliveryservice
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
|
|
This is ready for review despite AWS's throttling. |
|
/approve great work! |
cgwalters
reviewed
Mar 15, 2019
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
from
9469cd6 to
a622fae
Compare
openshift-ci-robot
added
size/L
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
from
a622fae to
7958574
Compare
pkg/controller had functions with confusing and unclear naming. This commit changes: generateMachineConfig() -> generateRenderedMachineConfig() generateMachineConfigs() -> generateTemplateMachineConfigs()
Add check to render_controller.go to ensure that all machineconfigs merged by getRenderedMachineConfig() contain valid ignition configs. Closes: openshift#502
kikisdeliveryservice
force-pushed
the
mcc-ign-check
branch
from
7958574 to
6444285
Compare
|
Updated. Ready for re-review @runcom @cgwalters |
|
still lgtm @cgwalters for the final lgtm |
|
/lgtm Nice work! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
getRenderedMachineConfig() contain valid ignition configs.
generateMachineConfig() -> generateRenderedMachineConfig()
generateMachineConfigs() -> generateTemplateMachineConfigs()
Closes: #502
Related-to: #505