OCPBUGS-57423: pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition

[wking]

Manually picking #4760 / #5111 back to 4.16, which is using coStatus instead of coStatusCondition, because it lacks #4321. Otherwise identical:

$ diff -U1 <(git show --oneline 377a78bb9fd2) <(git show --oneline 6bf0d7135d09)
--- /dev/fd/63  2025-06-12 10:41:31.352490108 -0700
+++ /dev/fd/62  2025-06-12 10:41:31.352490108 -0700
@@ -1,7 +1,7 @@
-377a78bb9 pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition
+6bf0d7135 pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition
 diff --git a/pkg/operator/status.go b/pkg/operator/status.go
-index 63699ec5c..eb015e005 100644
+index 69d37ad29..21a5ccc16 100644
 --- a/pkg/operator/status.go
 +++ b/pkg/operator/status.go
-@@ -285,13 +285,6 @@ func (optr *Operator) syncUpgradeableStatus(co *configv1.ClusterOperator) error
+@@ -316,13 +316,6 @@ func (optr *Operator) syncUpgradeableStatus() error {
                        break
@@ -12,5 +12,5 @@
 -      if updating && !degraded && !interrupted {
--              coStatusCondition.Status = configv1.ConditionFalse
--              coStatusCondition.Reason = "PoolUpdating"
--              coStatusCondition.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
+-              coStatus.Status = configv1.ConditionFalse
+-              coStatus.Reason = "PoolUpdating"
+-              coStatus.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
 -      }

[wking]

/jira cherry-pick OCPBUGS-57135

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
Once this PR has been reviewed and has the lgtm label, please assign djoshy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@wking: Jira Issue OCPBUGS-57135 has been cloned as Jira Issue OCPBUGS-57423. Will retitle bug to link to clone.
/retitle OCPBUGS-57423: pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition

In response to this:

/jira cherry-pick OCPBUGS-57135

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-57423, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-57135 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-57135 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manually picking #4760 / #5111 back to 4.16, which is using coStatus instead of coStatusCondition, because it lacks #4321. Otherwise identical:

$ diff -U1 <(git show --oneline 377a78bb9fd2) <(git show --oneline 6bf0d7135d09)
--- /dev/fd/63  2025-06-12 10:41:31.352490108 -0700
+++ /dev/fd/62  2025-06-12 10:41:31.352490108 -0700
@@ -1,7 +1,7 @@
-377a78bb9 pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition
+6bf0d7135 pkg/operator/status: Drop PoolUpdating as an Upgradeable=False condition
diff --git a/pkg/operator/status.go b/pkg/operator/status.go
-index 63699ec5c..eb015e005 100644
+index 69d37ad29..21a5ccc16 100644
--- a/pkg/operator/status.go
+++ b/pkg/operator/status.go
-@@ -285,13 +285,6 @@ func (optr *Operator) syncUpgradeableStatus(co *configv1.ClusterOperator) error
+@@ -316,13 +316,6 @@ func (optr *Operator) syncUpgradeableStatus() error {
                       break
@@ -12,5 +12,5 @@
-      if updating && !degraded && !interrupted {
--              coStatusCondition.Status = configv1.ConditionFalse
--              coStatusCondition.Reason = "PoolUpdating"
--              coStatusCondition.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
+-              coStatus.Status = configv1.ConditionFalse
+-              coStatus.Reason = "PoolUpdating"
+-              coStatus.Message = "One or more machine config pools are updating, please see `oc get mcp` for further details"
-      }

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

unit TestBuildControllerMultipleOptedInPools/Happy_Path_Multiple_Configs/master/CustomBuildPod panic doesn't look like it's touching any of the code I'm changing.

/retest-required

[openshift-ci]

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	6bf0d71	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node	6bf0d71	link	true	/test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-techpreview	6bf0d71	link	false	/test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sergiordlr]

/label cherry-pick-approved