Skip to content

Add infra-image flag to bootstrap.go as no-op #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

umohnani8
Copy link
Contributor

@umohnani8 umohnani8 commented Feb 25, 2019

Adding this, so we can get the installer PR openshift/installer#1292 in first
before landing in #471.
This is from an approved and lgtm'ed PR #471.

Signed-off-by: Urvashi Mohnani [email protected]

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2019
@umohnani8
Copy link
Contributor Author

@runcom @cgwalters @mrunalp PTAL

@kikisdeliveryservice
Copy link
Contributor

@umohnani8 can you update the PR / commit message to say that this is pulled from a lgtm'ed & approved PR and link it (if that is the case?).

Adding this, so we can get the installer PR in first
before landing in openshift#471.
This is from an approved and lgtm'ed PR openshift#471.

Signed-off-by: Urvashi Mohnani <[email protected]>
@umohnani8
Copy link
Contributor Author

@kikisdeliveryservice done!

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 25, 2019

@cgwalters
Copy link
Member

LGTM

@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@kikisdeliveryservice
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, smarterclayton, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umohnani8
Copy link
Contributor Author

/test e2e-aws-op

@kikisdeliveryservice
Copy link
Contributor

^^ e2e-aws failed with: aws_route.to_nat_gw.1: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s) rate limiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants