-
Notifications
You must be signed in to change notification settings - Fork 435
Add infra-image flag to bootstrap.go as no-op #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@runcom @cgwalters @mrunalp PTAL |
@umohnani8 can you update the PR / commit message to say that this is pulled from a lgtm'ed & approved PR and link it (if that is the case?). |
Adding this, so we can get the installer PR in first before landing in openshift#471. This is from an approved and lgtm'ed PR openshift#471. Signed-off-by: Urvashi Mohnani <[email protected]>
@kikisdeliveryservice done! |
Perfect, thanks @umohnani8 ! Just so I can find it again, PR is pulled directly from: https://github.com/openshift/machine-config-operator/pull/471/files?utf8=%E2%9C%93&diff=unified#diff-8fb88a4862bafc203a34072446df1407 |
LGTM |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, smarterclayton, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-op |
^^ e2e-aws failed with: |
Adding this, so we can get the installer PR openshift/installer#1292 in first
before landing in #471.
This is from an approved and lgtm'ed PR #471.
Signed-off-by: Urvashi Mohnani [email protected]