Skip to content

Fix broken links #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix broken links #242

merged 1 commit into from
Mar 4, 2019

Conversation

liangxia
Copy link
Member

@liangxia liangxia commented Mar 4, 2019

Follow up of #196

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2019
@ingvagabund
Copy link
Member

Hi @liangxia, thank you for the PR.

We are removing anything under test directory (see [1]). Though, all the crds under test/integration are just symlinks to those under install directory. Can you replace all test/integration paths with install? Otherwise, lgtm.

[1] #240

@liangxia
Copy link
Member Author

liangxia commented Mar 4, 2019

@ingvagabund Updated. Could you help check ?

@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit b9d5204 into openshift:master Mar 4, 2019
@liangxia liangxia deleted the fix-link branch March 4, 2019 12:00
@russellb russellb mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liangxia @ingvagabund @openshift-ci-robot @openshift-merge-robot