Skip to content

WIP: NOMERGE: DNM: consume u/s PR 126750 - take 2 #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: release-4.16
Choose a base branch
from
Open

WIP: NOMERGE: DNM: consume u/s PR 126750 - take 2 #2125

wants to merge 9 commits into from

Conversation

ffromani
Copy link

WIP DNM

sphrasavath and others added 9 commits October 29, 2024 15:55
@sphrasavath @ffromani
Add takeByTopologyUnCoreCachePacked if policy option align-cpus-by-u…
a626944 
…ncorecache is enabled.

(cherry picked from commit c90702d)
@sphrasavath @ffromani
New policy optino 'align-cpus-by-uncorecache' for Split L3 Topology t…
13acd7f 
…o take CPUs by uncourecache grouping.

(cherry picked from commit 4e76a74)
@sphrasavath @ffromani
Add policy & test cases
c94225d 
(cherry picked from commit 83db54d)
@ajcaldelas @ffromani
Adding new function to evaluate uncore cache id
268c675 
(cherry picked from commit 69bccda)
@sphrasavath @ffromani
reverse allocation logic
aaa3948 
(cherry picked from commit a44e5f5)
@wongchar @ffromani
implement preferAlignByUncorecache within TakeByTopologyNUMAPacked and
56dd0d5 
test cases

(cherry picked from commit 726e602)
@ajcaldelas @ffromani
simplified takepartial uncorecache and added logging. Added helper
4639b52 
function with unit tests

(cherry picked from commit 066f903)
@ffromani
backporting: compilation fixes
1281324 
adapt to the older codebase

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
UPSTREAM: <carry>: require configuration file enablement
84d184e 
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 29, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ffromani
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@openshift-ci openshift-ci bot requested review from rphillips and sjenning October 29, 2024 16:39
@ffromani
Copy link
Author

ffromani commented Nov 8, 2024

obsolete

@ffromani ffromani closed this Nov 8, 2024
@ffromani
Copy link
Author

/reopen

@openshift-ci openshift-ci bot reopened this May 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2025

@ffromani: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2025

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-crun 84d184e link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-cgroupsv2 84d184e link true /test e2e-aws-ovn-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ffromani @openshift-ci-robot @sphrasavath @ajcaldelas @wongchar