Skip to content

OCPBUGS-57526: Pick the last IP in the subnet #9804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Jun 20, 2025

Picking the last IP in the subnet for the internal LBIP. Previously, the 5th IP was being picked due to reservations for the first few IPs but if the users reserver more of the IPs at the start, the LBIP logic will not work. Choosing the last IP now to reduce the chances for error.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2025
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Jira Issue OCPBUGS-57526, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Picking the last IP in the subnet for the internal LBIP. Previously, the 5th IP was being picked due to reservations for the first few IPs but if the users reserver more of the IPs at the start, the LBIP logic will not work. Choosing the last IP now to reduce the chances for error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sadasu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jhixson74 and sadasu June 20, 2025 19:10
Picking the last IP in the subnet for the internal LBIP.
Previously, the 5th IP was being picked due to reservations
for the first few IPs but if the users reserver more of the IPs
at the start, the LBIP logic will not work. Choosing the last
IP now to reduce the chances for error.
@rna-afk rna-afk force-pushed the azure_lb_pick_last_ip branch from 6dd550e to 6b207c9 Compare June 23, 2025 01:02
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6b207c9 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-externallb-ovn 6b207c9 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-azurestack 6b207c9 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-shared-vpc 6b207c9 link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants