OCPBUGS-57923: When AWS_PROFILE is invalid ask for credentials #9803
Conversation
openshift-ci-robot
added
jira/severity-important
|
@barbacbd: This pull request references Jira Issue OCPBUGS-56658, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @patrickdillon |
barbacbd
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@barbacbd: This pull request references Jira Issue OCPBUGS-57923, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
barbacbd
force-pushed
the
OCPBUGS-56658-contd
branch
2 times, most recently
from
4548be2 to
a411bc3
Compare
There was a problem hiding this comment.
/lgtm
Tested with non-existing profile, existing profile without credentials, and no-profile-specified. The installer did ask for the credentials in the survey.
In the case where a profile exists and but credential is bad, the installer still fails, but this is expected as it seems more like user error :D
|
/cc @yunjiang29 |
|
pre-merge test get passed, LGTM |
** The credentials changed in AWS SDK V2. When the AWS_PROFILE environment variable was set to an invalid value the install would not proceed through the failure. The inention was to ask for the aws key and id information. Now the information will be added to the survey, and the information will be added to the config in .aws.
barbacbd
force-pushed
the
OCPBUGS-56658-contd
branch
from
a411bc3 to
d5e983a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
** The credentials changed in AWS SDK V2. When the AWS_PROFILE environment variable was set to an invalid value the install would not proceed through the failure. The inention was to ask for the aws key and id information. Now the information will be added to the survey, and the information will be added to the config in .aws.