-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[release-4.19] OCPBUGS-57039: ensure ctrplane nodes can access bootstrap MCS #9768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.19] OCPBUGS-57039: ensure ctrplane nodes can access bootstrap MCS #9768
Conversation
When using BYO subnets, users might define subnets in aws.vpc.subnets and define the machineCIDRs in the installconfig from those subnets. Previously, an SG is attached to api lb that only allows ingress to tcp/22623 (MCS) from the only the first machineCIDR, which blocks master nodes from reaching MCS on bootstrap node. This commit adjusts the source for the SG to allow ingress from control plane nodes via SG reference instead of relying on the machineCIDR field.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-54502 has been cloned as Jira Issue OCPBUGS-57039. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57039, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@tthvo: This pull request references Jira Issue OCPBUGS-57039, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @yunjiang29 We are looking to backport this fix to 4.16.z. Hope the release note gives a decent description for the fix :D |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
/label cherry-pick-approved |
96ef056
into
openshift:release-4.19
@openshift-cherrypick-robot: Jira Issue OCPBUGS-57039: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57039 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
/cherry-pick release-4.18 |
@tthvo: new pull request created: #9772 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix included in accepted release 4.19.0-0.nightly-2025-06-06-115013 |
This is an automated cherry-pick of #9689
/assign tthvo