CORS-4053: Migrate AWS SDK to v2 in cluster/aws #9762
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-4053 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pkg/asset/cluster/aws/aws.go
Outdated
| if err != nil { | ||
| return errors.Wrap(err, "could not create AWS session") | ||
| return fmt.Errorf("failed loading default config: %w", err) |
There was a problem hiding this comment.
nit: Another place to change to failed to load AWS config while you are at it haha
barbacbd
force-pushed
the
CORS-4053
branch
2 times, most recently
from
53fdfc0 to
fb6f62c
Compare
|
/label platform/aws |
** The IAM, EC2, and Route53 clients were moved to SDK v2. This included migration from session to config (and use of endpoints).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
** The IAM, EC2, and Route53 clients were moved to SDK v2. This included migration from session to config (and use of endpoints).