Skip to content

OCPBUGS-54413: Make swift containers removal not fatal for UPI. #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

gryf
Copy link
Member

@gryf gryf commented May 20, 2025

When there is OpenStack deployment, which doesn't have swift services, or there are no containers used at all, listing them will fail the playbook and leave exit code other than 0, which may interrupt CI.

With this commit, errors from listing containers will be ignored, which will cover both cases.

When there is OpenStack deployment, which doesn't have swift services,
or there are no containers used at all, listing them will fail the
playbook and leave exit code other than 0, which may interrupt CI.

With this commit, errors from listing containers will be ignored, which
will cover both cases.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2025
@openshift-ci-robot
Copy link
Contributor

@gryf: This pull request references Jira Issue OCPBUGS-54413, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When there is OpenStack deployment, which doesn't have swift services, or there are no containers used at all, listing them will fail the playbook and leave exit code other than 0, which may interrupt CI.

With this commit, errors from listing containers will be ignored, which will cover both cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from MaysaMacedo and stephenfin May 20, 2025 12:14
@gryf
Copy link
Member Author

gryf commented May 20, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2025
@openshift-ci-robot
Copy link
Contributor

@gryf: This pull request references Jira Issue OCPBUGS-54413, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@sadasu
Copy link
Contributor

sadasu commented May 28, 2025

/approve

Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b21fbe7 and 2 for PR HEAD 7ec4cdf in total

Copy link
Contributor

openshift-ci bot commented May 28, 2025

@gryf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 7ec4cdf link false /test e2e-openstack-proxy
ci/prow/e2e-vsphere-ovn-multi-network 7ec4cdf link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-externallb-ovn 7ec4cdf link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-openstack-dualstack-upi 7ec4cdf link false /test e2e-openstack-dualstack-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e5ae366 and 1 for PR HEAD 7ec4cdf in total

@openshift-merge-bot openshift-merge-bot bot merged commit 88ba667 into openshift:main May 29, 2025
18 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@gryf: Jira Issue OCPBUGS-54413: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54413 has been moved to the MODIFIED state.

In response to this:

When there is OpenStack deployment, which doesn't have swift services, or there are no containers used at all, listing them will fail the playbook and leave exit code other than 0, which may interrupt CI.

With this commit, errors from listing containers will be ignored, which will cover both cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.20.0-202505290744.p0.g88ba667.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202505290744.p0.g88ba667.assembly.stream.el9.
All builds following this will include this PR.

@gryf
Copy link
Member Author

gryf commented Jun 2, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot

@gryf: new pull request created: #9765

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants