*: Drop tectonic-system namespace

[wking]

The kube-addon operator was the last remaining component in that namespace, and it was just controlling a metrics server. Metrics aren't critical to cluster functions, and dropping kube-addon means we don't need the old pull secret anymore (although we will shortly need new pull secrets for pulling private release images).

[abhinavdahiya]

/lgtm

[abhinavdahiya]

/lgtm cancel

[abhinavdahiya]

@wking can you also drop role admin and role user both are not required anymore.

[sjenning]

fyi metrics-server is being replaced with the prometheus metrics adapter anyway. i'm looking forward to this merging! big milestone.

[wking]

... can you also drop role admin and role user both are not required anymore.

Dropped with 2ff4e5e -> af1d523. I'm going to reap CI to get some EIP headroom too.

[wking]

Diff from my current ad6abd3 vs. #681:

 Gopkg.lock                                                           |   16 +--
 Gopkg.toml                                                           |    4 -
 docs/design/resource_dep.svg                                         | 1186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------
 docs/dev/libvirt-howto.md                                            |    2 +-
 pkg/asset/manifests/tectonic.go                                      |   23 +++-
 vendor/github.com/coreos/tectonic-config/LICENSE                     |  201 ---------------------------------
 vendor/github.com/coreos/tectonic-config/config/kube-addon/config.go |   23 ----
 vendor/k8s.io/apimachinery/pkg/util/rand/rand.go                     |  120 --------------------
 8 files changed, 693 insertions(+), 882 deletions(-)

I like the vendor, SVG, and doc differences. I'm not sure about:

diff --git a/pkg/asset/manifests/tectonic.go b/pkg/asset/manifests/tectonic.go
index b3c067a..b90ac5a 100644
--- a/pkg/asset/manifests/tectonic.go
+++ b/pkg/asset/manifests/tectonic.go
@@ -6,6 +6,7 @@ import (
 
        "github.com/aws/aws-sdk-go/aws/session"
        "github.com/ghodss/yaml"
+       "github.com/pkg/errors"
 
        "github.com/gophercloud/utils/openstack/clientconfig"
        "github.com/openshift/installer/pkg/asset"
@@ -20,12 +21,15 @@ const (
 )
 
 var (
+       tectonicConfigPath = filepath.Join(tectonicManifestDir, "00_cluster-config.yaml")
+
        _ asset.WritableAsset = (*Tectonic)(nil)
 )
 
 // Tectonic generates the dependent resource manifests for tectonic (as against bootkube)
 type Tectonic struct {
-       FileList []*asset.File
+       TectonicConfig *configurationObject
+       FileList       []*asset.File
 }
 
 // Name returns a human friendly name for the operator
@@ -145,6 +149,21 @@ func (t *Tectonic) Load(f asset.FileFetcher) (bool, error) {
                return false, nil
        }
 
-       t.FileList = fileList
+       tectonicConfig := &configurationObject{}
+       var found bool
+       for _, file := range fileList {
+               if file.Filename == tectonicConfigPath {
+                       if err := yaml.Unmarshal(file.Data, tectonicConfig); err != nil {
+                               return false, errors.Wrapf(err, "failed to unmarshal 00_cluster-config.yaml")
+                       }
+                       found = true
+               }
+       }
+
+       if !found {
+               return false, nil
+       }
+
+       t.FileList, t.TectonicConfig = fileList, tectonicConfig
        return true, nil
 }

Should I drop some/all of that, and if so, why?

[abhinavdahiya]

@wking we are not setting that field anymore, so can drop it.

[wking]

... we are not setting that field anymore, so need to drop it

Ok, dropped with ad6abd3 -> a14da04. We'll see if I've released enough EIPs...

[abhinavdahiya]

i think we got all/most of what we could drop.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment