CONTRIBUTING: Drop stale structure-check references #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting --workdir and passing ${@} through means:
$ ./hack/shellcheck.sh
will show any errors with relative paths that will still work outside
the container. For example:
./tests/smoke/.build/external/go_sdk/src/syscall/mkall.sh:278:7: note: Expressions don't expand in single quotes, use double quotes for that. [SC2016]
instead of:
/workdir/tests/smoke/.build/external/go_sdk/src/syscall/mkall.sh:278:7: note: Expressions don't expand in single quotes, use double quotes for that. [SC2016]
Adding prune rules for vendor and .build under tests/smoke avoids
complaining about that file and others over which are maintained
upstream or elsewhere.
openshift-ci-robot
added
approved
This way they can use: $ hack/tf-fmt.sh -list -check to update their local Terraform (vs. just checking if it's correctly formatted). I've also dropped the read-only mount option to support this use case. I use set [1] to inject default args if the caller set no positional args themselves [2], so the test config in openshift/release continues to work. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#set [2]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_05_02
wking
force-pushed
the
drop-structure-check-references
branch
from
9520115 to
9108c3a
Compare
They haven't worked since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137). Recommend out new hack/* scripts instead.
wking
force-pushed
the
drop-structure-check-references
branch
from
9108c3a to
0581e47
Compare
|
The e2e-aws and e2e-aws-smoke errors were: That seems to be a Docker issue with a fix in-flight upstream (moby/moby#37781), but the patch may still need percolating out into various Red Hat consumers (rhbz#1625457 rhbz#1628262). |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 17, 2018
We want to stuff these in when the user gave us no arguments, not clobber arguments when the user passed some in :p. Fixes a bug from 4b9cbdd (hack/tf-fmt: Allow callers to pass positional args, 2018-09-13, openshift#248).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They haven't worked since d61abd4 (coreos/tectonic-installer#3137). Recommend out new
hack/*scripts instead.I've also included two commits to make those hack scripts easier for devs to use. Details on those changes in their commit messages.