Skip to content

Rename labels from sigs.k8s.io to machine.openshift.io #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2019
Merged

Rename labels from sigs.k8s.io to machine.openshift.io #1263

merged 1 commit into from
Feb 28, 2019

Conversation

spangenberg
Copy link
Contributor

/cc bison

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2019
@enxebre enxebre mentioned this pull request Feb 18, 2019
Merged
@spangenberg spangenberg mentioned this pull request Feb 18, 2019
Merged
@enxebre
Copy link
Member

enxebre commented Feb 19, 2019

/hold
needs openshift/cluster-api-provider-aws#161 (comment)

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 19, 2019
@enxebre enxebre mentioned this pull request Feb 25, 2019
Merged
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2019
@frobware
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@ingvagabund
Copy link
Member

/test e2e-aws

@enxebre
Copy link
Member

enxebre commented Feb 26, 2019

this is blocked by openshift/machine-api-operator#213

@spangenberg
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@spangenberg
Copy link
Contributor Author

/test e2e-aws

@spangenberg
Copy link
Contributor Author

/retest

@ingvagabund
Copy link
Member

@abhinavdahiya PTAL

@abhinavdahiya
Copy link
Contributor

/approve

cc @flaper87 will changes to openstack manifests look good.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, frobware, spangenberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@enxebre enxebre mentioned this pull request Feb 28, 2019
Closed
@openshift-merge-robot openshift-merge-robot merged commit 9596c7f into openshift:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@spangenberg @enxebre @frobware @ingvagabund @abhinavdahiya @openshift-ci-robot @openshift-merge-robot