Skip to content

HIVE-2767: konflux/mce-2.8 fix configs (take 2) #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mce-2.8
Choose a base branch
from

Conversation

dlom
Copy link
Contributor

@dlom dlom commented Apr 16, 2025

xref: HIVE-2767

$ diff mce-2.8-on-pull mce-2.9-on-pull
13c13
<       && target_branch == "mce-2.8"
---
>       && target_branch == "master"
17,18c17,18
<     appstudio.openshift.io/application: release-mce-28
<     appstudio.openshift.io/component: hive-mce-28
---
>     appstudio.openshift.io/application: release-mce-29
>     appstudio.openshift.io/component: hive-mce-29
20c20
<   name: hive-mce-28-on-pull-request
---
>   name: hive-mce-29-on-pull-request
29c29
<     value: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hive-mce-28:on-pr-{{revision}}
---
>     value: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hive-mce-29:on-pr-{{revision}}
628c628
<     serviceAccountName: build-pipeline-hive-mce-28
---
>     serviceAccountName: build-pipeline-hive-mce-29

supersedes a few PRs:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever April 16, 2025 18:54
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2025
@dlom dlom closed this Jun 10, 2025
@dlom dlom reopened this Jun 10, 2025
@dlom
Copy link
Contributor Author

dlom commented Jun 10, 2025

/retitle HIVE-2767: konflux/mce-2.8 fix configs (take 2)

@openshift-ci openshift-ci bot changed the title [WIP] konflux/mce-2.8 fix configs (take 2) HIVE-2767: konflux/mce-2.8 fix configs (take 2) Jun 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@dlom: This pull request references HIVE-2767 which is a valid jira issue.

In response to this:

xref: HIVE-2676

supersedes a few PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@dlom: This pull request references HIVE-2767 which is a valid jira issue.

In response to this:

xref: HIVE-2767

supersedes a few PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@dlom: This pull request references HIVE-2767 which is a valid jira issue.

In response to this:

xref: HIVE-2767

supersedes a few PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@dlom: This pull request references HIVE-2767 which is a valid jira issue.

In response to this:

xref: HIVE-2767

$ diff mce-2.8-on-pull mce-2.9-on-pull
13c13
<       && target_branch == "mce-2.8"
---
>       && target_branch == "master"
17,18c17,18
<     appstudio.openshift.io/application: release-mce-28
<     appstudio.openshift.io/component: hive-mce-28
---
>     appstudio.openshift.io/application: release-mce-29
>     appstudio.openshift.io/component: hive-mce-29
20c20
<   name: hive-mce-28-on-pull-request
---
>   name: hive-mce-29-on-pull-request
29c29
<     value: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hive-mce-28:on-pr-{{revision}}
---
>     value: quay.io/redhat-user-workloads/crt-redhat-acm-tenant/hive-mce-29:on-pr-{{revision}}
628c628
<     serviceAccountName: build-pipeline-hive-mce-28
---
>     serviceAccountName: build-pipeline-hive-mce-29

supersedes a few PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom
Copy link
Contributor Author

dlom commented Jun 10, 2025

/assign @2uasimojo

@dlom
Copy link
Contributor Author

dlom commented Jun 10, 2025

/override ci/prow/security
This should be fixed in a separate PR

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

In response to this:

/override ci/prow/security
This should be fixed in a separate PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@dlom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f5f57ba link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member

Looks like we're missing a file.

But are we wanting to do this at all in the mce-2.8 branch? Aren't we trying to consolidate everything into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants