Skip to content

Bug 1679272 - Validate console can talk to OAuth token URL #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

spadgett
Copy link
Member

Make sure we can successfully talk to the OAuth token URL after
discovering metadata before marking the console pod as ready.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1679272

/cc @enj @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
Make sure we can successfully talk to the OAuth token URL after
discovering metadata before marking the console pod as ready.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1679272
@spadgett spadgett changed the title [WIP] Bug 1679272 - Validate console can talk to OAuth token URL Bug 1679272 - Validate console can talk to OAuth token URL Feb 21, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2019
@enj
Copy link
Contributor

enj commented Feb 21, 2019

Lets not log the kube:admin password 😄

Done in 91.42s.
/go/src/github.com/openshift/console
++ cat /tmp/artifacts/installer/auth/kubeadmin-password
+ oc login -u kubeadmin -p VsoMr-j2rLI-eE4Vc-vWuSj
Error from server (InternalError): Internal error occurred: unexpected response: 400
+ copyArtifacts
Copying artifacts from /go/src/github.com/openshift/console...
++ pwd
+ echo 'Copying artifacts from /go/src/github.com/openshift/console...'
+ cp -rv ./frontend/gui_test_screenshots /tmp/artifacts/gui_test_screenshots
cp: cannot stat './frontend/gui_test_screenshots': No such file or directory

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@spadgett
Copy link
Member Author

Lets not log the kube:admin password 😄

Yeah, that's fixed in #1197

@spadgett spadgett mentioned this pull request Feb 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit be656a7 into openshift:master Feb 21, 2019
@spadgett spadgett deleted the validate-token-url branch February 21, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants