Skip to content

Monitoring: The "DeadMansSwitch" alert has been renamed to "Watchdog" #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Feb 15, 2019

This fixes the Cluster Status page's "Alerts Firing" count to exclude the Watchdog alert.

FYI @brancz

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2019
@kyoto
Copy link
Member Author

kyoto commented Feb 15, 2019

/retest

1 similar comment
@kyoto
Copy link
Member Author

kyoto commented Feb 15, 2019

/retest

@brancz
Copy link

brancz commented Feb 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019
@spadgett
Copy link
Member

/retest

1 similar comment
@kyoto
Copy link
Member Author

kyoto commented Feb 19, 2019

/retest

@spadgett
Copy link
Member

Hopefully #1197 fixes ci

@spadgett
Copy link
Member

/retest

2 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

level=fatal msg="waiting for bootstrap-complete: timed out waiting for the condition"

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

@kyoto needs rebase

@kyoto kyoto force-pushed the monitoring-watchdog-alert-rename branch from 4a8eaf7 to c47c76f Compare February 25, 2019 03:05
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@kyoto
Copy link
Member Author

kyoto commented Feb 25, 2019

@spadgett Rebased

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@spadgett
Copy link
Member

/retest

3 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@kyoto
Copy link
Member Author

kyoto commented Feb 25, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit c527bb5 into openshift:master Feb 25, 2019
@kyoto kyoto deleted the monitoring-watchdog-alert-rename branch February 25, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants