Skip to content

Fix wrapping API groups in Resource Dropdown #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolethoen
Copy link
Member

Fixes CONSOLE-787

screen shot 2019-01-29 at 10 37 08 am

@nicolethoen nicolethoen requested a review from spadgett January 29, 2019 15:48
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2019
@spadgett
Copy link
Member

/assign @rhamilto

@nicolethoen nicolethoen force-pushed the resource_dropdown_api_groups branch from e758c40 to 246bbb1 Compare January 29, 2019 19:52
@nicolethoen nicolethoen force-pushed the resource_dropdown_api_groups branch from 246bbb1 to 1f1e647 Compare February 1, 2019 16:48
@nicolethoen
Copy link
Member Author

/retest

1 similar comment
@nicolethoen
Copy link
Member Author

/retest

@nicolethoen nicolethoen force-pushed the resource_dropdown_api_groups branch from 1f1e647 to 88ab69c Compare February 5, 2019 16:56
@openshift-merge-robot
Copy link
Contributor

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

/retest

@nicolethoen
Copy link
Member Author

@spadgett is this waiting for anything else?

@benjaminapetersen
Copy link
Contributor

@rhamilto is out this week, taking a look

@nicolethoen
Copy link
Member Author

Before:
screen shot 2019-02-14 at 11 21 24 am
After:
screen shot 2019-02-14 at 11 23 38 am

@benjaminapetersen
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@nicolethoen
Copy link
Member Author

/retest

1 similar comment
@nicolethoen
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9bfcbc6 into openshift:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants