OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193
Conversation
…ta1 between 4.19 and 4.20.
| @@ -8,3 +8,6 @@ metadata: | |||
| include.release.openshift.io/hypershift: "true" | |||
| include.release.openshift.io/ibm-cloud-managed: "true" | |||
| include.release.openshift.io/self-managed-high-availability: "true" | |||
| data: | |||
| ack-4.19-admissionregistration-v1beta1-api-removals-in-4.20: |- | |||
| The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20. | |||
There was a problem hiding this comment.
| The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20. | |
| The admissionregistration.k8s.io/v1beta1 API group version is deprecated and will be removed in 4.20. Clients must instead use the corresponding resources in the admissionregistration.k8s.io/v1 group version. |
Nit: "Group version" is an appropriate term for this. Also, I don't know what the style conventions are for these messages, but stronger phrasing seems appropriate for the recommendation. Ignoring it means breaking any client that depends on the old GV.
|
/retest-required |
jacobsee
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@jacobsee: This pull request references Jira Issue OCPBUGS-57488, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal |
openshift-ci
bot
changed the title
|
@jacobsee: This pull request references Jira Issue OCPBUGS-55937, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
pre-merge tested the PR, looks good, detail see https://issues.redhat.com/browse/OCPBUGS-55937?focusedId=27478523&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27478523 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrisonnet, jacobsee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@dgrisonnet: This pull request references Jira Issue OCPBUGS-55937, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
New changes are detected. LGTM label has been removed. |
|
@jacobsee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Add upgrade gate for the removal of admissionregistration.k8s.io/v1beta1 between 4.19 and 4.20.