Skip to content

STOR-1064: add volume-data-source-validator controller #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Jun 23, 2025

Adds Volume Data Source Validator controller to CSO. We're still waiting for ART onboarding so currently there is no validator production image available, however this PR can be tested earlier locally (if needed) with custom image built from validator repo and later verified with production images. This image is loaded by CSO via env. variable VOLUME_DATA_SOURCE_VALIDATOR_IMAGE which can point to custom image built from the validator repo.

For more details see the linked epic and enhancement doc: openshift/enhancements#1784

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2025

@RomanBednar: This pull request references STOR-1064 which is a valid jira issue.

In response to this:

Adds Volume Data Source Validator controller to CSO. We're still waiting for ART onboarding so currently there is no validator production image available, however this PR can be tested earlier locally (if needed) with custom image built from validator repo and later verified with production images. This image is loaded by CSO via env. variable VOLUME_DATA_SOURCE_VALIDATOR_IMAGE which can point to custom image built from the validator repo.

For more details see the linked epic and enhancement doc: openshift/enhancements#1784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana June 23, 2025 09:17
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2025

@RomanBednar: This pull request references STOR-1064 which is a valid jira issue.

In response to this:

Adds Volume Data Source Validator controller to CSO. We're still waiting for ART onboarding so currently there is no validator production image available, however this PR can be tested earlier locally (if needed) with custom image built from validator repo and later verified with production images. This image is loaded by CSO via env. variable VOLUME_DATA_SOURCE_VALIDATOR_IMAGE which can point to custom image built from the validator repo.

For more details see the linked epic and enhancement doc: openshift/enhancements#1784

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-aws-e2e-external 6ed797a link true /test hypershift-aws-e2e-external
ci/prow/okd-scos-e2e-aws-ovn 6ed797a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-manual-oidc 6ed797a link false /test e2e-gcp-manual-oidc
ci/prow/e2e-aws-ovn-upgrade 6ed797a link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-csi 6ed797a link true /test e2e-vsphere-csi
ci/prow/e2e-azure-file-csi 6ed797a link true /test e2e-azure-file-csi
ci/prow/hypershift-e2e-aks 6ed797a link true /test hypershift-e2e-aks
ci/prow/e2e-openstack 6ed797a link false /test e2e-openstack
ci/prow/e2e-aws-csi 6ed797a link true /test e2e-aws-csi
ci/prow/e2e-ibmcloud-csi 6ed797a link false /test e2e-ibmcloud-csi
ci/prow/e2e-gcp-csi 6ed797a link true /test e2e-gcp-csi
ci/prow/e2e-azure-csi 6ed797a link true /test e2e-azure-csi
ci/prow/e2e-openstack-parallel 6ed797a link false /test e2e-openstack-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants