Skip to content

[release-4.17] OCPBUGS-58066: Add cert-rotation script into cno #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-58066: Add cert-rotation script into cno #2729

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2702

/assign bpickard22

@bpickard22
Add cert-rotation script into cno
1ecc3a0 
update install-cni script to match whereabouts bin so that we get cert
rotatation in openshift

we have to break the tokenwatcher section of the whereabouts script out
because it was running in an init container, so it would never
"complete", hanging the rollout

to accomplish this I created a new whereabouts watcher ds to house this
section of the script

Signed-off-by: Benjamin Pickard <[email protected]>
(cherry picked from commit 6e82842)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58047 has been cloned as Jira Issue OCPBUGS-58066. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-58066: Add cert-rotation script into cno

In response to this:

This is an automated cherry-pick of #2702

/assign bpickard22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-58047: Add cert-rotation script into cno [release-4.17] OCPBUGS-58066: Add cert-rotation script into cno Jun 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 24, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-58066, which is invalid:

  • expected dependent Jira Issue OCPBUGS-58047 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2702

/assign bpickard22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and trozet June 24, 2025 19:55
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-upgrade-from-stable-4.16-e2e-aws-ovn-ipsec-upgrade 1ecc3a0 link false /test 4.17-upgrade-from-stable-4.16-e2e-aws-ovn-ipsec-upgrade
ci/prow/e2e-azure-ovn 1ecc3a0 link false /test e2e-azure-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt 1ecc3a0 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 1ecc3a0 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 1ecc3a0 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/security 1ecc3a0 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bpickard22
Copy link
Contributor

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

Assignees

@bpickard22 bpickard22

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @bpickard22