Skip to content

[release-4.17] OCPBUGS-57285: Implement IPsec NAT-Traversal encapsulation option #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from

Conversation

pperiyasamy
Copy link
Member

Manual cherry-pick of 4.18 commit d660f37.
Bump openshift/api version to consume IPsec encapsulation API.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2025
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-57285, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56183 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-56183 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of 4.18 commit d660f37.
Bump openshift/api version to consume IPsec encapsulation API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 16, 2025
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The following commands are run for API bump:

go get github.com/openshift/[email protected]
go mod vendor
make update-codegen

Signed-off-by: Periyasamy Palanisamy <[email protected]>
This commit consumes configuration parameters for the IPsec `Full`
mode, it currently has encapsulation option to configure OVN so
that inter pod traffic across node are encapsulated to handle NAT
traversal. So it implements the following.

1. When the encapsulation option is set with "Always", then enforce NAT-T
encapsulation on the OVN.
2. When the encapsulation option is set with "Auto" or the config option
for full mode is never set, then it continues to render the "auto" option
for NAT-T encapsulation.
3. On the IBMCloud platform, NAT-T encapsulation is always enforced.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
(cherry picked from commit 50899e2)
(cherry picked from commit d660f37)
@pperiyasamy pperiyasamy force-pushed the ipsec-nat-t-feature-4.17 branch from e280654 to 5997958 Compare June 17, 2025 07:36
@huiran0826
Copy link

passed: (5m56s) 2025-06-18T06:15:10 "[sig-networking] SDN IPSEC EW Author:huirwang-High-80099-Verify encapsulation=Always/Auto works. [Disruptive] [Serial]"

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jun 18, 2025
@pperiyasamy
Copy link
Member Author

/assign @jcaamano

@pperiyasamy
Copy link
Member Author

/retest-required

@pperiyasamy
Copy link
Member Author

/retest

@pperiyasamy
Copy link
Member Author

/test ?

Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

@pperiyasamy: The following commands are available to trigger required jobs:

/test 4.17-upgrade-from-stable-4.16-images
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-ipsec-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test 4.17-upgrade-from-stable-4.16-e2e-aws-ovn-ipsec-upgrade
/test 4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
/test 4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
/test 4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade
/test e2e-aws-hypershift-ovn-kubevirt
/test e2e-aws-ovn-ipsec-serial
/test e2e-aws-ovn-local-to-shared-gateway-mode-migration
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-techpreview-serial
/test e2e-azure-ovn
/test e2e-azure-ovn-dualstack
/test e2e-azure-ovn-manual-oidc
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-network-mtu-migration-ovn-ipv4
/test e2e-network-mtu-migration-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-ovn-hybrid-step-registry
/test e2e-ovn-ipsec-step-registry
/test e2e-ovn-step-registry
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-dualstack
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-windows
/test okd-scos-images
/test qe-perfscale-aws-ovn-medium-cluster-density
/test qe-perfscale-aws-ovn-medium-node-density-cni
/test qe-perfscale-aws-ovn-small-cluster-density
/test qe-perfscale-aws-ovn-small-node-density-cni
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-network-operator-release-4.17-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-ipsec-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-4.17-upgrade-from-stable-4.16-images
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-hypershift-ovn-kubevirt
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-hypershift-conformance
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-local-to-shared-gateway-mode-migration
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-serial
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-shared-to-local-gateway-mode-migration
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-windows
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-azure-ovn
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-azure-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-gcp-ovn
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-gcp-ovn-techpreview
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-gcp-ovn-upgrade
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-metal-ipi-ovn-ipv6-ipsec
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-network-mtu-migration-ovn-ipv4
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-network-mtu-migration-ovn-ipv6
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-openstack-ovn
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-ovn-hybrid-step-registry
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-ovn-ipsec-step-registry
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-ovn-step-registry
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-vsphere-ovn
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-vsphere-ovn-dualstack
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-vsphere-ovn-dualstack-primaryv6
pull-ci-openshift-cluster-network-operator-release-4.17-images
pull-ci-openshift-cluster-network-operator-release-4.17-lint
pull-ci-openshift-cluster-network-operator-release-4.17-security
pull-ci-openshift-cluster-network-operator-release-4.17-unit
pull-ci-openshift-cluster-network-operator-release-4.17-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 5997958 link false /test e2e-openstack-ovn
ci/prow/4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade 5997958 link false /test 4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
ci/prow/e2e-ovn-ipsec-step-registry 5997958 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 5997958 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security 5997958 link false /test security
ci/prow/e2e-azure-ovn-upgrade 5997958 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-ovn 5997958 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node 5997958 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-ovn-hybrid-step-registry 5997958 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-hypershift-ovn-kubevirt 5997958 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 5997958 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 5997958 link false /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-network-mtu-migration-ovn-ipv4 5997958 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-ovn-step-registry 5997958 link false /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants