-
Notifications
You must be signed in to change notification settings - Fork 245
OCPBUGS-42303: QE;DNM; Gate ovn-controller starting post reboot until ovnkube controller syncs #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@martinkennelly: This pull request references Jira Issue OCPBUGS-42303, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkennelly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nb; must check if sno or other deployments aren't IC. |
/retest |
408f6e8
to
0012fdb
Compare
This commit fixes OCPBUGS-42303. If ovn-controller starts before ovnkube-controller syncs and the changes propagated to SB DB, then ovn-controller will consume stale SB DB data. This PR gates starting ovn-controller until ovnkube controller syncs. ovnkube-controller emits a file to non-persistent storage and we predicate the start on this. Signed-off-by: Martin Kennelly <[email protected]>
0012fdb
to
58d2fa8
Compare
/testwith openshift/ovn-kubernetes/master/e2e-aws-ovn-upgrade ovn-kubernetes/ovn-kubernetes#5315 |
@martinkennelly,
|
/testwith openshift/ovn-kubernetes/master/e2e-aws-ovn-upgrade openshift/ovn-kubernetes#2626 |
/testwith openshift/ovn-kubernetes/master/e2e-aws-ovn openshift/ovn-kubernetes#2626 |
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
TODO; Must investigate if this is the right approach for all deployments. We need IC enabled.
This commit fixes OCPBUGS-42303.
If ovn-controller starts before ovnkube-controller syncs and the changes propagated to SB DB, then ovn-controller will consume stale SB DB data. This PR gates starting ovn-controller until ovnkube controller syncs. ovnkube-controller emits a file to non-persistent storage and we predicate the start on this.
/hold
/cc
cc @huiran0826