Skip to content

CORENET-5856: Update RouteAdvertisements schema #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

CORENET-5856: Update RouteAdvertisements schema #2685

merged 1 commit into from
Apr 17, 2025

Conversation

jcaamano
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2025 •
edited by openshift-ci bot
Loading

@jcaamano: This pull request references CORENET-5856 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and trozet April 11, 2025 13:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@jcaamano
Copy link
Contributor Author

/hold

want to merge this with corresponding ovnk/origin/release PRs as close to each other as possible

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2025
@jcaamano jcaamano mentioned this pull request Apr 14, 2025
Merged
@jluhrsen
Copy link
Contributor

/hold

want to merge this with corresponding ovnk/origin/release PRs as close to each other as possible

@jcaamano , which PRs are these?

@jcaamano
Update RouteAdvertisements schema
90652c8 
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 16, 2025

/lgtm

@jcaamano
Copy link
Contributor Author

/hold
want to merge this with corresponding ovnk/origin/release PRs as close to each other as possible

@jcaamano , which PRs are these?

Having LGTM here is good enough

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0508612 and 2 for PR HEAD 90652c8 in total

@jluhrsen
Copy link
Contributor

/retest

1 similar comment
@jcaamano
Copy link
Contributor Author

/retest

@pliurh
Copy link
Contributor

pliurh commented Apr 17, 2025

/retest-required

1 similar comment
@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

/retest-required

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

CI is broken currently, the jobs that are failing are not affected by this change since the CRD is only installed on techpreview lanes when BGP is then enabled through the network config.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

/retest-required

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2685/pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-ipsec-upgrade/1912815350626390016 - console failure, probably due to: openshift/console-operator#979
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2685/pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6-ipsec/1912815350810939392 - ci outage image issue, not related
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2685/pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6/1912815350773190656 - ci outage image issue, not related
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2685/pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade/1912815350706081792 - console failure, probably due to: openshift/console-operator#979

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

/override ci/prow/e2e-aws-ovn-ipsec-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-ipsec-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

In response to this:

/override ci/prow/e2e-aws-ovn-ipsec-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt 90652c8 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-single-node 90652c8 link false /test e2e-aws-ovn-single-node
ci/prow/security 90652c8 link false /test security
ci/prow/4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade 90652c8 link false /test 4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 90652c8 link false /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 90652c8 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/okd-scos-e2e-aws-ovn 90652c8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 90652c8 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-ovn-step-registry 90652c8 link false /test e2e-ovn-step-registry
ci/prow/e2e-network-mtu-migration-ovn-ipv6 90652c8 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade 90652c8 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 90652c8 link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 50405c0 into openshift:master Apr 17, 2025
25 of 37 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.19.0-202504180114.p0.g50405c0.assembly.stream.el9.
All builds following this will include this PR.

@pliurh
Copy link
Contributor

pliurh commented Apr 18, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcaamano @openshift-ci-robot @jluhrsen @kyrtapz @pliurh @openshift-bot