-
Notifications
You must be signed in to change notification settings - Fork 246
CORENET-5914: bindata,ovn-k: Update CUDN CRD following localnet support #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORENET-5914: bindata,ovn-k: Update CUDN CRD following localnet support #2678
Conversation
@ormergi: This pull request references SDN-5519 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ormergi: This pull request references SDN-5519 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4f4c718
to
a26e42a
Compare
a26e42a
to
d8204fa
Compare
The ClusterUserDefinedNetwork CRD has been extended and no support creating localnet topology networks. Signed-off-by: Or Mergi <[email protected]>
d8204fa
to
1dc00e0
Compare
@ormergi: This pull request references CORENET-5914 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @ricky-rav |
/retest-required |
/lgtm |
@kyrtapz PTAL |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, ormergi, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/tide refresh |
/retest-required |
/retest-required |
/retest-required |
1 similar comment
/retest-required |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@ormergi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The ci/prow/e2e-aws-ovn-upgrade consistently failing due to issues that doesnt seem related to this PR changes.
|
/retest-required |
/hold we need to get the OVN-K PR in too and it is currently struggling with all the CI issues. |
/retest-required |
/hold cancel |
/override ci/prow/e2e-azure-ovn-upgrade the tests passed. |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-azure-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-aws-ovn-upgrade |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-aws-ovn-windows |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-gcp-ovn-techpreview |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-ovn-ipsec-step-registry |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-ovn-ipsec-step-registry In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
bcf7b32
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
The ClusterUserDefinedNetwork CRD has been extended and now support creating localnet topology networks.