Skip to content

CORENET-5914: bindata,ovn-k: Update CUDN CRD following localnet support #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Apr 1, 2025

The ClusterUserDefinedNetwork CRD has been extended and now support creating localnet topology networks.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@ormergi: This pull request references SDN-5519 which is a valid jira issue.

In response to this:

The ClusterUserDefinedNetwork CRD has been extended and no support creating localnet topology networks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Apr 1, 2025

cc @ricky-rav @asood-rh

@openshift-ci openshift-ci bot requested review from abhat and danwinship April 1, 2025 18:14
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@ormergi: This pull request references SDN-5519 which is a valid jira issue.

In response to this:

The ClusterUserDefinedNetwork CRD has been extended and now support creating localnet topology networks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi ormergi force-pushed the ocn-k-cudn-localnet branch from 4f4c718 to a26e42a Compare April 7, 2025 14:33
@ormergi ormergi force-pushed the ocn-k-cudn-localnet branch from a26e42a to d8204fa Compare April 16, 2025 17:59
The ClusterUserDefinedNetwork CRD has been extended and no support
creating localnet topology networks.

Signed-off-by: Or Mergi <[email protected]>
@ormergi ormergi force-pushed the ocn-k-cudn-localnet branch from d8204fa to 1dc00e0 Compare April 16, 2025 18:00
@ormergi ormergi changed the title SDN-5519: bindata,ovn-k: Update CUDN CRD following localnet support CORENET-5914: bindata,ovn-k: Update CUDN CRD following localnet support Apr 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2025

@ormergi: This pull request references CORENET-5914 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

The ClusterUserDefinedNetwork CRD has been extended and now support creating localnet topology networks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi
Copy link
Contributor Author

ormergi commented Apr 17, 2025

/cc @ricky-rav

@openshift-ci openshift-ci bot requested a review from ricky-rav April 17, 2025 07:05
@ormergi
Copy link
Contributor Author

ormergi commented Apr 17, 2025

/retest-required

@ricky-rav
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@ricky-rav
Copy link
Contributor

ricky-rav commented Apr 17, 2025

@kyrtapz PTAL
Its related ovnk PR is: ovn-kubernetes/ovn-kubernetes#5010

@ricky-rav
Copy link
Contributor

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, ormergi, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 17, 2025

/retest-required

@tssurya
Copy link
Contributor

tssurya commented Apr 17, 2025

/tide refresh

@tssurya
Copy link
Contributor

tssurya commented Apr 17, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 50405c0 and 2 for PR HEAD 1dc00e0 in total

@trozet
Copy link
Contributor

trozet commented Apr 17, 2025

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 50405c0 and 2 for PR HEAD 1dc00e0 in total

@ricky-rav
Copy link
Contributor

/retest-required

1 similar comment
@ricky-rav
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b0aaa7d and 1 for PR HEAD 1dc00e0 in total

@zshi-redhat
Copy link
Contributor

/retest-required

2 similar comments
@ormergi
Copy link
Contributor Author

ormergi commented Apr 21, 2025

/retest-required

@ormergi
Copy link
Contributor Author

ormergi commented Apr 21, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 1dc00e0 link false /test e2e-aws-ovn-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 1dc00e0 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade 1dc00e0 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 1dc00e0 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt 1dc00e0 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade 1dc00e0 link false /test 4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
ci/prow/security 1dc00e0 link false /test security
ci/prow/e2e-network-mtu-migration-ovn-ipv6 1dc00e0 link false /test e2e-network-mtu-migration-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ormergi
Copy link
Contributor Author

ormergi commented Apr 21, 2025

The ci/prow/e2e-aws-ovn-upgrade consistently failing due to issues that doesnt seem related to this PR changes.
It seems to fail to create the cluster on AWS, due to various failures on different stages, for example:

 level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed during pre-provisioning: failed to create IAM roles: failed to create IAM master role: failed to create master role: LimitExceeded: Cannot exceed quota for RolesPerAccount: 1000 

example

 level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: platform.aws.publicIpv4PoolId: Internal error: required a minimum of 16 Public IPv4 IPs available in the pool ipv4pool-ec2-0768267342e327ea9, got 12 

example

 level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: infrastructure was not ready within 15m0s: context deadline exceeded 

example

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 22, 2025

/retest-required

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 22, 2025

/hold

we need to get the OVN-K PR in too and it is currently struggling with all the CI issues.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 22, 2025

/retest-required

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6268c4e and 2 for PR HEAD 1dc00e0 in total

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-azure-ovn-upgrade

the tests passed.

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-azure-ovn-upgrade

In response to this:

/override ci/prow/e2e-azure-ovn-upgrade

the tests passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-aws-ovn-upgrade
the tests passed, it failed after

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/e2e-aws-ovn-upgrade
the tests passed, it failed after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-aws-ovn-windows
this is a known bug

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows
this is a known bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-gcp-ovn-techpreview
unrelated test failure

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview
unrelated test failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
the job is extremely flaky and the test passed before

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec
the job is extremely flaky and the test passed before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Apr 23, 2025

/override ci/prow/e2e-ovn-ipsec-step-registry
job/failure are unrelated to this change, passed before.

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-ovn-ipsec-step-registry

In response to this:

/override ci/prow/e2e-ovn-ipsec-step-registry
job/failure are unrelated to this change, passed before.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bcf7b32 into openshift:master Apr 23, 2025
29 of 37 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.19.0-202504231110.p0.gbcf7b32.assembly.stream.el9.
All builds following this will include this PR.

@ormergi ormergi deleted the ocn-k-cudn-localnet branch April 23, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants