Skip to content

Move to use newer IPsec DaemonSets when MCP is in paused state #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pperiyasamy
Copy link
Member

@pperiyasamy pperiyasamy commented Jul 26, 2024

When MCP is in paused state, network operator continues to render older IPsec daemonsets which blocks network cluster operator not getting upgraded to 4.15. Hence this commit renders both newer 4.15 IPsec daemonsets for intermediate period. When MCPs are moved to unpaused state and IPsec machine configs are installed on it, then it goes ahead with rendering only host flavored IPsec daemonset.

@openshift-ci openshift-ci bot requested review from abhat and kyrtapz July 26, 2024 08:18
@pperiyasamy pperiyasamy force-pushed the debug-mcp-pause-ipsec-blocking-upgrade branch from 7c6b3ce to 29843fa Compare July 31, 2024 06:50
@pperiyasamy pperiyasamy changed the title Debug blocking ipsec upgrade due to mcp pause Move to use newer IPsec DaemonSets when MCP is in paused state Jul 31, 2024
@pperiyasamy
Copy link
Member Author

/assign @yuvalk @jcaamano @anuragthehatter

@pperiyasamy
Copy link
Member Author

created a PR #2454 on master branch with few more fixes in the ipsec manifest files. Let's do the review at #2454.
Still keeping this PR which may be used for 4.15 backport.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
This commit makes network operator to use MachineConfigPool, it
currently checks only status, but going forward it may check pause
value which is a mcp Spec parameter.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
(cherry picked from commit ae8938daca4ba38b69d516482a887f5c03191382)
When MCP is in paused state, network operator continues to render older
IPsec daemonsets which blocks network cluster operator not getting upgraded
to newer version. Hence this commit renders newer IPsec daemonsets for
intermediate period. When MCPs are moved to unpaused state and IPsec machine
configs are installed on it, then it goes ahead with rendering only host
flavored IPsec daemonset.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
(cherry picked from commit 64be52482981c75ed387b0e497dddb047778f13e)
@pperiyasamy pperiyasamy force-pushed the debug-mcp-pause-ipsec-blocking-upgrade branch from 29843fa to 9d88c89 Compare August 21, 2024 13:26
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please ask for approval from jcaamano. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy
Copy link
Member Author

/test ?

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@pperiyasamy: The following commands are available to trigger required jobs:

  • /test 4.15-upgrade-from-stable-4.14-images
  • /test e2e-aws-live-migration-sdn-ovn
  • /test e2e-aws-ovn-network-migration
  • /test e2e-aws-ovn-windows
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-hypershift-ovn
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
  • /test 4.15-upgrade-from-stable-4.14-e2e-azure-ovn-upgrade
  • /test 4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade
  • /test e2e-aws-hypershift-ovn-kubevirt
  • /test e2e-aws-live-migration-sdn-ovn-rollback
  • /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-sdn-upgrade
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-manual-oidc
  • /test e2e-metal-ipi-ovn-ipv6-ipsec
  • /test e2e-network-mtu-migration-ovn-ipv4
  • /test e2e-network-mtu-migration-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-ovn-ipsec-step-registry
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-dualstack
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-windows
  • /test qe-perfscale-aws-ovn-medium-cluster-density
  • /test qe-perfscale-aws-ovn-medium-node-density-cni
  • /test qe-perfscale-aws-ovn-small-cluster-density
  • /test qe-perfscale-aws-ovn-small-node-density-cni
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-network-operator-release-4.15-4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-release-4.15-4.15-upgrade-from-stable-4.14-e2e-azure-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-release-4.15-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-release-4.15-4.15-upgrade-from-stable-4.14-images
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-hypershift-ovn-kubevirt
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-live-migration-sdn-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-live-migration-sdn-ovn-rollback
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-network-migration
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-shared-to-local-gateway-mode-migration
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-windows
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-sdn-upgrade
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-azure-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-gcp-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-hypershift-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-metal-ipi-ovn-ipv6-ipsec
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-network-mtu-migration-ovn-ipv4
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-network-mtu-migration-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-openstack-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-ovn-ipsec-step-registry
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-ovn-step-registry
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-vsphere-ovn
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-vsphere-ovn-dualstack
  • pull-ci-openshift-cluster-network-operator-release-4.15-e2e-vsphere-ovn-dualstack-primaryv6
  • pull-ci-openshift-cluster-network-operator-release-4.15-images
  • pull-ci-openshift-cluster-network-operator-release-4.15-lint
  • pull-ci-openshift-cluster-network-operator-release-4.15-security
  • pull-ci-openshift-cluster-network-operator-release-4.15-unit
  • pull-ci-openshift-cluster-network-operator-release-4.15-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pperiyasamy
Copy link
Member Author

/test e2e-ovn-ipsec-step-registry
/test e2e-aws-ovn-ipsec-upgrade

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 9d88c89 link false /test e2e-aws-ovn-single-node
ci/prow/security 9d88c89 link false /test security
ci/prow/4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade 9d88c89 link false /test 4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade
ci/prow/4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade 9d88c89 link false /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 9d88c89 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-network-mtu-migration-ovn-ipv4 9d88c89 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-aws-hypershift-ovn-kubevirt 9d88c89 link false /test e2e-aws-hypershift-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anuragthehatter
Copy link

QE test looks good to me on this PR
https://privatebin.corp.redhat.com/?1a43cd1aaeefed0d#BZ6VVTeVso7PYRSCv65xSfEniDFMJnGWseRN3ezBhEfi

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 29, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 28, 2024
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 28, 2025
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants