Skip to content

Change kube-controllers targets to separated scheduler and controller-manager #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Change kube-controllers targets to separated scheduler and controller-manager #177

merged 1 commit into from
Jan 10, 2019

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Dec 5, 2018

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2018
s-urbaniak
s-urbaniak approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

let's wait until installer merges the actual cloud settings first before merging.

@brancz
Copy link
Contributor Author

brancz commented Dec 5, 2018

agreed

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2018
@s-urbaniak
Copy link
Contributor

/refresh

@s-urbaniak
Copy link
Contributor

/retest

@s-urbaniak
Copy link
Contributor

/refresh

@s-urbaniak
Copy link
Contributor

/retest

1 similar comment
@s-urbaniak
Copy link
Contributor

/retest

squat
squat approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@brancz
Copy link
Contributor Author

brancz commented Jan 10, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2019
@brancz
Copy link
Contributor Author

brancz commented Jan 10, 2019

/refresh

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@squat
Copy link
Contributor

squat commented Jan 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,s-urbaniak,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz
Copy link
Contributor Author

brancz commented Jan 10, 2019

/retest

1 similar comment
@brancz
Copy link
Contributor Author

brancz commented Jan 10, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit baf7915 into openshift:master Jan 10, 2019
@brancz brancz deleted the sched-cm branch January 10, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@squat squat squat approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@squat squat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brancz @s-urbaniak @squat @openshift-ci-robot @openshift-merge-robot