Improves zapr logger contextual information #133
Conversation
openshift-ci-robot
added
the
size/S
| if err != nil { | ||
| panic(fmt.Sprintf("error building logger: %v", err)) | ||
| } | ||
| defer zapLogger.Sync() |
There was a problem hiding this comment.
Food for thought: deferred calls aren't honored if main.main exits, right? Seems like another reason to manage logging setup/cleanup closer to the entry point and outside init() (to increase the odds of successfully flushing prior to a crash)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
PR #126 was merged before implementing final touches to improve contextual information of log messages. This PR prevents reporting the wrapper code as the caller and reduces the verbosity of logger names.