operator: change source of apiURL to infrastructure.config.openshift.io

[abhinavdahiya]

Infrastructre global config 1 contains the URL to the APIServer and therefore using the cluster-config-v1 to create the apiURL is not required.

Also installer#1169 2 is changing the structure of the DNS names, and console is redirecting to old apiserver URL.

installer#1169 has feature exception approval and we need to make that in for feature feature for bea2 as upgradabililty into new DNS name is difficult.

[stlaz]

Thank you for your changes. However, all of the changed code goes away in #59 so unless the CI is broken, I would refrain from any changes to it.

[stlaz]

/hold

[abhinavdahiya]

As I mentioned in the previous overview, the installer teams wants to merge openshift/installer#1169 today before feature freeze as that change is disruptive. The CI on 1169 is green but merging that without this PR means users will not be able to access console due to the wrong apiurl being generated by current auth operator.

So it would be nice if we can go ahead with this change for now at least unblocking us as #59 seems to be blocked for now
#59 (comment)

[stlaz]

If we need to have this done, let's merge openshift/installer#1242 which already has LGTM, then we can have #59 and then this PR won't be necessary.

[ericavonb]

/lgtm

[ericavonb]

/hold cancel

[ericavonb]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ericavonb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ericavonb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

/retest

[crawford]

The last failure was due to rate limits:

level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route_table_association.route_net[3]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.3: timeout while waiting for state to become 'success' (timeout: 5m0s)"

[crawford]

Failed because of a known bug:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[abhinavdahiya]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[enj]

/hold

You have already missed feature freeze. #59 is the correct path to accomplish what you need.

[crawford]

#59 isn't merged yet (and doesn't appear to be ready) and this PR will unblock changes that are needed for the Beta 2 release. I was told that can be safely merged before #59. Given the critical nature of the changes that are gated on this PR, I'm going to override your /hold. This isn't a feature; it's a bug.

/hold cancel

[smarterclayton]

I agree with @crawford's override

[enj]

#59 isn't merged yet (and doesn't appear to be ready) and this PR will unblock changes that are needed for the Beta 2 release. I was told that can be safely merged before #59. Given the critical nature of the changes that are gated on this PR, I'm going to override your /hold. This isn't a feature; it's a bug.

/hold cancel

All of the changes are required for beta2 either way. I would have expected @openshift/sig-auth to workaround the cert issues by disabling the CA check in the bootstrap user test. That would nullify the need for this change and allow #59 to merge. It is a much smaller hack that gets us closer to what we need to ship in beta2.

I agree with @crawford's override

No worries there. I will sort it out next week.