Skip to content

Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.8.3 (3cced50) into main #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

richardcase and others added 4 commits April 9, 2025 16:53
The version of calico used in our e2e tests was 2 years old so this
updates to the current latest version. This will help ensure that there
are no issues with the latest version of calico.

Signed-off-by: Richard Case <[email protected]>
…ot/cherry-pick-5459-to-release-2.8

[release-2.8] 🌱 chore: bump calico for e2e tests
…ot/cherry-pick-5458-to-release-2.8

[release-2.8] 🐛 fix(addons): avoid infinite reconciliation loop
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2025
Copy link

openshift-ci bot commented Jun 2, 2025

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from damdo and sub-mod June 2, 2025 12:26
Copy link

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented Jun 4, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@damdo
Copy link
Member

damdo commented Jun 5, 2025

/override ci/prow/security

@damdo
Copy link
Member

damdo commented Jun 5, 2025

/test e2e-aws-serial-2of2

Copy link

openshift-ci bot commented Jun 5, 2025

@damdo: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • security

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-capi-techpreview
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-techpreview
  • ci/prow/e2e-aws-serial-1of2
  • ci/prow/e2e-aws-serial-2of2
  • ci/prow/e2e-hypershift
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/regression-clusterinfra-aws-ipi-proxy-techpreview
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify-commits
  • ci/prow/verify-deps
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-capi-techpreview
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-ovn
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-ovn-techpreview
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-serial-1of2
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-serial-2of2
  • pull-ci-openshift-cluster-api-provider-aws-main-e2e-hypershift
  • pull-ci-openshift-cluster-api-provider-aws-main-images
  • pull-ci-openshift-cluster-api-provider-aws-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-cluster-api-provider-aws-main-okd-scos-images
  • pull-ci-openshift-cluster-api-provider-aws-main-regression-clusterinfra-aws-ipi-proxy-techpreview
  • pull-ci-openshift-cluster-api-provider-aws-main-security
  • pull-ci-openshift-cluster-api-provider-aws-main-unit
  • pull-ci-openshift-cluster-api-provider-aws-main-verify-commits
  • pull-ci-openshift-cluster-api-provider-aws-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jun 5, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Jun 5, 2025

This CAPA v2.8.3 patch release doesn't have kubernetes-sigs#5374 as that was merged upstream on April 10th and is going to land in v2.9.0.

In the meanwhile though the rebasebot detected the PR got merged and so it is dropping it from this CAPA v2.8.3 rebase, even if it is not contained in that release.

This is an issue with the rebasebot that we need to fix. cc. @RadekManak

@damdo
Copy link
Member

damdo commented Jun 5, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2025
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-main branch 2 times, most recently from 2b90410 to 7b02837 Compare June 9, 2025 12:23
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-main branch 2 times, most recently from 170d9c7 to 4445941 Compare June 19, 2025 12:25
joshbranham and others added 12 commits June 26, 2025 12:19
…Allows It

modified version of the original
UPSTREAM: <carry>: Only tag NetworkInterfaces in RunInstances if IAM Allows It, adapt to rebase
to adapt it to the upstream code changes.
# Conflicts:
#	openshift/infrastructure-components.yaml
Copy link

openshift-ci bot commented Jun 26, 2025

@cloud-team-rebase-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security c053280 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants