Skip to content

Rename AWS credentials secret data keys #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

Rename AWS credentials secret data keys #164

merged 1 commit into from
Feb 25, 2019

Conversation

spangenberg
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2019
@spangenberg
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@dgoodwin
Copy link

👍 thanks for doing this, this keeps everyone using cred secrets that I know of in sync so far.

@ingvagabund
Copy link
Member

@spangenberg can you provide more context? Why is it needed?

@spangenberg
Copy link
Author

spangenberg commented Feb 21, 2019 •
edited
Loading

@spangenberg can you provide more context? Why is it needed?

@ingvagabund Sure, the cloud credential operator has a different secret data mapping compared to the one we have.

https://github.com/openshift/cloud-credential-operator/blob/47261953fd5974ba24072148d53ec4c919f6ad8f/pkg/controller/secretannotator/secretannotator_controller.go#L64-L65

@spangenberg
Copy link
Author

/retest

@spangenberg spangenberg marked this pull request as ready for review February 21, 2019 15:49
@bison
Copy link

bison commented Feb 22, 2019

/retest

My only concern is whether we need backward comparability, but it's probably not a big deal at this stage.

@spangenberg
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@ingvagabund
Copy link
Member

IINM, only our CI was consumer of the AWS secrets. Otherwise, in OpenShift it was aws instance profile that provided means to communicate with AWS service(s).

@ingvagabund
Copy link
Member

ingvagabund commented Feb 22, 2019 •
edited
Loading

/approve

fine for me though I want another review to confirm/disprove my statement

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
bison
bison approved these changes Feb 25, 2019
View reviewed changes
Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@paulfantom
Copy link

/refresh

@spangenberg
Copy link
Author

spangenberg commented Feb 25, 2019 •
edited
Loading

VPC limit reached.

/test e2e

@paulfantom
Copy link

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7a541ff into openshift:master Feb 25, 2019
spangenberg added a commit to spangenberg/machine-api-operator that referenced this pull request Feb 26, 2019
@spangenberg
Incorporate changed AWS credentials secret data keys
b11d70f 
See openshift/cluster-api-provider-aws#164
@spangenberg spangenberg mentioned this pull request Feb 26, 2019
Merged
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Feb 26, 2019
@enxebre
Update aws creds data keys
b8488f8 
See openshift/cluster-api-provider-aws#164
spangenberg added a commit to spangenberg/machine-api-operator that referenced this pull request Feb 26, 2019
@spangenberg
Incorporate changed AWS credentials secret data keys
73c2f83 
See openshift/cluster-api-provider-aws#164
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Feb 26, 2019
@enxebre
Update aws creds data keys
ab0ca25 
See openshift/cluster-api-provider-aws#164
michaelgugino pushed a commit to mgugino-upstream-stage/cluster-api-provider-aws that referenced this pull request Feb 12, 2020
@vincepri @k8s-ci-robot
Fix ansible temp folder directory (openshift#164)
351cd29 
Fixes openshift#142

Signed-off-by: Vince Prignano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@spangenberg @dgoodwin @ingvagabund @bison @openshift-ci-robot @paulfantom @openshift-merge-robot