OCPBUGS-51090: Fix panic for GetZoneByNodeName on Azure Stack

[patrickdillon]

Azure Stack does not support the API Version, 2020-12-01, for PlatformFaultDomain, and therefore panics when we run the cloud provider on Azure Stack. This avoids the panic, but we cannot get the correct PlatformFaultDomain (which may not be an issue).

[patrickdillon]

/wip
I will open an upstream issue. Opening this now for testing

[patrickdillon]

I have confirmed this fixes the panic upstream

Opened issue and pull request upstream:
kubernetes-sigs#8754
kubernetes-sigs#8755

[nrb]

lgtm, will wait for tests before doing an approve.

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

This has already merged upstream: kubernetes-sigs#8755

So I think it would be best to just pick this up in a rebase.

[nrb]

@patrickdillon it will be easiest from our side to merge this and then have this carry commit dropped automatically later

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-51090, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Azure Stack does not support the API Version, 2020-12-01, for PlatformFaultDomain, and therefore panics when we run the cloud provider on Azure Stack. This avoids the panic, but we cannot get the correct PlatformFaultDomain (which may not be an issue).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/jira refresh

[nrb]

/lgtm
/approve

[patrickdillon]

/jira refresh

fat fingers

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-51090, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

fat fingers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nrb]

/tide refresh

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@patrickdillon: Jira Issue OCPBUGS-51090: All pull requests linked via external trackers have merged:

• openshift/cloud-provider-azure#141

Jira Issue OCPBUGS-51090 has been moved to the MODIFIED state.

In response to this:

Azure Stack does not support the API Version, 2020-12-01, for PlatformFaultDomain, and therefore panics when we run the cloud provider on Azure Stack. This avoids the panic, but we cannot get the correct PlatformFaultDomain (which may not be an issue).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-cloud-controller-manager
This PR has been included in build ose-azure-cloud-controller-manager-container-v4.19.0-202504111744.p0.g8e579f3.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-cloud-node-manager
This PR has been included in build ose-azure-cloud-node-manager-container-v4.19.0-202504111744.p0.g8e579f3.assembly.stream.el9.
All builds following this will include this PR.