Skip to content

DPTP-4341: fix snapshot tag references #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

DPTP-4341: fix snapshot tag references #4618

merged 4 commits into from
Jul 11, 2025

Conversation

deepsm007
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from danilo-gemoli and Prucek July 3, 2025 12:11
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2025 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4341 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

/hold

/cc @danilo-gemoli @Prucek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 4 times, most recently from 8ba194a to 7f3e373 Compare July 3, 2025 14:24
@deepsm007
Copy link
Contributor Author

/test e2e

Prucek
Prucek reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@Prucek Prucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified if the referencePolicy is not set, it would default to source?

@deepsm007
Copy link
Contributor Author

/test e2e

Prucek
Prucek reviewed Jul 4, 2025
View reviewed changes
@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 3 times, most recently from 87e7c4d to dfe1534 Compare July 4, 2025 19:08
@deepsm007
Copy link
Contributor Author

/test e2e

Prucek
Prucek suggested changes Jul 7, 2025
View reviewed changes
Prucek
Prucek reviewed Jul 7, 2025
View reviewed changes
@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 2 times, most recently from cbc73b7 to 7662de4 Compare July 8, 2025 14:45
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2025
@deepsm007 deepsm007 closed this Jul 8, 2025
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@deepsm007 deepsm007 force-pushed the DPTP-4341 branch 3 times, most recently from d4cc3af to 0ce7984 Compare July 10, 2025 20:37
@deepsm007
Copy link
Contributor Author

/test e2e

1 similar comment
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007
Copy link
Contributor Author

/label tide/merge-method-squash
/unhold

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 10, 2025
droslean
droslean reviewed Jul 11, 2025
View reviewed changes
droslean
droslean reviewed Jul 11, 2025
View reviewed changes
droslean
droslean reviewed Jul 11, 2025
View reviewed changes
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007 deepsm007 changed the title DPTP-4341: fix output tag references DPTP-4341: fix snapshot tag references Jul 11, 2025
@deepsm007
Copy link
Contributor Author

/test e2e

@deepsm007
Copy link
Contributor Author

/test images

@droslean
Copy link
Member

/lgtm
/approve

/bark

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@droslean: dog image

In response to this:

/lgtm
/approve

/bark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@openshift-ci-robot
Copy link
Contributor

/test remaining-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes b9675ad link false /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2a5b667 into openshift:main Jul 11, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droslean droslean droslean left review comments

@Prucek Prucek Prucek approved these changes

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

Assignees

@droslean droslean

@Prucek Prucek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepsm007 @openshift-ci-robot @Prucek @droslean @openshift-merge-robot