Skip to content

[DPTP-4313] Respecting always_run from config file #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hector-vido
Copy link
Contributor

@hector-vido hector-vido commented Mar 18, 2025

Basically I added the optional option that was being ignored during presubmit creation of the image jobs.

if len(imageTargets) > 0 {
// Identify which jobs need to have a release payload explicitly requested
var presubmitTargets = sets.List(imageTargets)
if api.PromotesOfficialImages(configSpec, api.WithOKD) {
presubmitTargets = append(presubmitTargets, "[release:latest]")
}
imagesTestName := "images"
jobBaseGen := newJobBaseBuilder().TestName(imagesTestName)
injectArchitectureLabels(jobBaseGen, configSpec.Images)
optional := false
for _, image := range configSpec.Images {
if image.Optional {
optional = true
break
}
}
jobBaseGen.PodSpec.Add(Targets(presubmitTargets...))
presubmits[orgrepo] = append(presubmits[orgrepo], *generatePresubmitForTest(jobBaseGen, imagesTestName, info, func(options *generatePresubmitOptions) {
options.optional = optional
}))

		jobBaseGen.PodSpec.Add(Targets(presubmitTargets...))
		presubmits[orgrepo] = append(presubmits[orgrepo], *generatePresubmitForTest(jobBaseGen, imagesTestName, info, func(options *generatePresubmitOptions) {
			options.optional = optional
		}))

And cleaned some priorities based on previous release/ci-operator/jobs for some fields.

@openshift-ci openshift-ci bot requested review from droslean and smg247 March 18, 2025 22:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@hector-vido hector-vido force-pushed the respecting-always-run branch from b93df6f to 6cacf19 Compare March 18, 2025 23:00
@hector-vido hector-vido force-pushed the respecting-always-run branch 4 times, most recently from 3a774ad to ad4d383 Compare March 24, 2025 03:24
@hector-vido
Copy link
Contributor Author

/test unit

@jmguzik
Copy link
Contributor

jmguzik commented Mar 24, 2025

/hold

Evaluation is needed if the function that assigns old values makes sense

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@hector-vido hector-vido force-pushed the respecting-always-run branch from ad4d383 to 0148be1 Compare April 14, 2025 15:13
@hector-vido
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
@hector-vido hector-vido force-pushed the respecting-always-run branch from 0148be1 to 72b96a0 Compare April 14, 2025 16:56
@hector-vido hector-vido force-pushed the respecting-always-run branch 2 times, most recently from b908cfc to fd4cabd Compare April 25, 2025 02:42
@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido
Copy link
Contributor Author

/test images

@hector-vido
Copy link
Contributor Author

/test e2e

2 similar comments
@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido hector-vido force-pushed the respecting-always-run branch from fd4cabd to 4170932 Compare May 7, 2025 02:47
@hector-vido
Copy link
Contributor Author

/hold

@hector-vido hector-vido force-pushed the respecting-always-run branch from 2dceb5f to 0a2eb06 Compare July 3, 2025 19:45
@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido hector-vido force-pushed the respecting-always-run branch from 0a2eb06 to 53c762d Compare July 3, 2025 19:49
@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido hector-vido force-pushed the respecting-always-run branch 2 times, most recently from 864d6b6 to 25b970a Compare July 10, 2025 22:05
@hector-vido hector-vido force-pushed the respecting-always-run branch 3 times, most recently from 25ce5b1 to deb44b4 Compare July 11, 2025 16:41
@hector-vido hector-vido force-pushed the respecting-always-run branch 2 times, most recently from 4db4a52 to 38bae77 Compare July 12, 2025 04:41
@hector-vido
Copy link
Contributor Author

/test e2e

@hector-vido
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@openshift-ci-robot
Copy link
Contributor

/test remaining-required

Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hector-vido,jmguzik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hector-vido hector-vido force-pushed the respecting-always-run branch from 38bae77 to 3ce8591 Compare July 15, 2025 20:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

New changes are detected. LGTM label has been removed.

@hector-vido
Copy link
Contributor Author

/test e2e

1 similar comment
@hector-vido
Copy link
Contributor Author

/test e2e

Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

@hector-vido: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 3ce8591 link false /test breaking-changes
ci/prow/e2e 3ce8591 link true /test e2e
ci/prow/images 3ce8591 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants