-
Notifications
You must be signed in to change notification settings - Fork 284
[DPTP-4313] Respecting always_run from config file #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b93df6f
to
6cacf19
Compare
3a774ad
to
ad4d383
Compare
/test unit |
/hold Evaluation is needed if the function that assigns old values makes sense |
ad4d383
to
0148be1
Compare
/unhold |
0148be1
to
72b96a0
Compare
b908cfc
to
fd4cabd
Compare
/test e2e |
/test images |
/test e2e |
2 similar comments
/test e2e |
/test e2e |
/test e2e |
fd4cabd
to
4170932
Compare
/hold |
2dceb5f
to
0a2eb06
Compare
/test e2e |
0a2eb06
to
53c762d
Compare
/test e2e |
864d6b6
to
25b970a
Compare
25ce5b1
to
deb44b4
Compare
4db4a52
to
38bae77
Compare
/test e2e |
/retest |
/test remaining-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido, jmguzik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
38bae77
to
3ce8591
Compare
New changes are detected. LGTM label has been removed. |
/test e2e |
1 similar comment
/test e2e |
@hector-vido: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Basically I added the
optional
option that was being ignored during presubmit creation of the image jobs.ci-tools/pkg/prowgen/prowgen.go
Lines 124 to 145 in 4db4a52
And cleaned some priorities based on previous
release/ci-operator/jobs
for some fields.