This repository was archived by the owner on Jul 11, 2023. It is now read-only.
cert rotation now ignores monotonic clock readings when checking expiration #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steeling
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer and
keithmattix
as code owners
steeling
force-pushed
the
feature/primer
branch
from
e7a2bab to
755f89e
Compare
…ration Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/primer
branch
from
755f89e to
2ad9c7d
Compare
keithmattix
approved these changes
Aug 17, 2022
shashankram
approved these changes
Aug 17, 2022
|
Any idea when this is planned to be released for implementation. We are also facing the same issue as highlighted in #5000 |
|
What version of OSM are you using? |
|
1.1.1 and our AKS version is 1.23.8 |
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
Signed-off-by: Shalier Xia <[email protected]> cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
Signed-off-by: Shalier Xia <[email protected]> cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
Signed-off-by: Shalier Xia <[email protected]> cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Oct 18, 2022
cert rotation now ignores monotonic clock readings when checking expiration (openservicemesh#5012) Signed-off-by: Sean Teeling <[email protected]> Signed-off-by: Shalier Xia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumed fix for #5000. More details in the comment #5000 (comment)
(even if this is not the issue, this would still be the correct way to check the x509 expiration)
Signed-off-by: Sean Teeling [email protected]