This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Add @keithmattix as a codeowner maintainer #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@keithmattix has been contributing to the project at the level that is expected of a maintainer to include: Designs and implementations of feature work, complex bug triaging and fixing, and indepth and sustained code reviews raising the quality of the product. **Maintainers**, if you agree with this nomination, leave a "+1" comment and approve the PR (do not merge it). Signed-off-by: Thomas Stringer <[email protected]>
trstringer
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
jaellio
as code owners
|
Thanks for the nomination Thomas! |
draychev
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
@keithmattix Has been a great driver in the SMI and OSM communities and adding him to the code owners is well deserved.
|
This is good to merge as a majority (4/6) of the existing maintainers are in agreement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keithmattix has been contributing to the project at the level that is
expected of a maintainer to include: Designs and implementations of
feature work, complex bug triaging and fixing, and indepth and sustained
code reviews raising the quality of the product.
Maintainers, if you agree with this nomination, leave a "+1" comment
and approve the PR (do not merge it).
Signed-off-by: Thomas Stringer [email protected]
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No.
Is this a breaking change? No.
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? N/A