Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Separate bootstrap building logic into the envoy/bootstrap package #4838

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

steeling
Copy link
Contributor

This PR separates the bootstrap config build logic into the bootstrap package. There are 0 "logic" code changes, only moving code around, exporting previously unexported functions, and prefacing methods/types with the new package name.

The main reason to do this is that there are changes coming with respect to rotating the secrets with the bootstrap config. Because of this, we will need to modify how we are creating and writing the bootstrap config.

Currently the code is tightly coupled with generating the config and writing it. This PR begins the process of decoupling, and brings us closer the the builder pattern we plan on implementing.

The main changes include:

  1. Move HealthProbes, which are an internal construct, to a separate models package, so that it can be used by both the injector and the bootstrap builder.
  2. Move all code that is involved in building the bootstrap config to the bootstrap package. A subsequent PR will make actual changes to create a logical builder.

@jaellio
Copy link
Contributor

jaellio commented Jun 21, 2022

Can this be noted as part of #4839?

@steeling
Copy link
Contributor Author

Can this be noted as part of #4839?

This would actually be part of #4818

@steeling steeling marked this pull request as ready for review June 22, 2022 01:22
Copy link
Contributor

@shalier shalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sean Teeling <[email protected]>
@jaellio jaellio merged commit 226ee64 into openservicemesh:main Jun 29, 2022
@jaellio jaellio linked an issue Jul 7, 2022 that may be closed by this pull request
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OSM bootstrap secret on certificate manager updates
4 participants