This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Separate bootstrap building logic into the envoy/bootstrap package #4838
+560
−587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the bootstrap config build logic into the bootstrap package. There are 0 "logic" code changes, only moving code around, exporting previously unexported functions, and prefacing methods/types with the new package name.
The main reason to do this is that there are changes coming with respect to rotating the secrets with the bootstrap config. Because of this, we will need to modify how we are creating and writing the bootstrap config.
Currently the code is tightly coupled with generating the config and writing it. This PR begins the process of decoupling, and brings us closer the the builder pattern we plan on implementing.
The main changes include: