This repository was archived by the owner on Jul 11, 2023. It is now read-only.
(feat: certs) MeshRootStatus -> ProviderState #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schristoff
changed the title
steeling
reviewed
Jun 13, 2022
jaellio
reviewed
Jun 13, 2022
jaellio
reviewed
Jun 13, 2022
jaellio
reviewed
Jun 13, 2022
schristoff
commented
Jun 14, 2022
jaellio
reviewed
Jun 14, 2022
jaellio
reviewed
Jun 14, 2022
jaellio
reviewed
Jun 14, 2022
jaellio
reviewed
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #4812 +/- ##
==========================================
- Coverage 68.58% 68.51% -0.07%
==========================================
Files 223 224 +1
Lines 16259 16168 -91
==========================================
- Hits 11151 11078 -73
+ Misses 5057 5038 -19
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
schristoff
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
trstringer
as code owners
steeling
reviewed
Jun 15, 2022
nojnhuh
approved these changes
Jun 15, 2022
Add additional MRC state constants to have all rollout and rollback stages. Remove RotationStage and keep only the single state. Signed-off-by: Sarah Christoff <[email protected]>
schristoff
force-pushed
the
schristoff_updateMRCStatus
branch
from
aaea07e to
e47a291
Compare
jaellio
reviewed
Jun 16, 2022
Signed-off-by: Sarah Christoff <[email protected]>
jaellio
approved these changes
Jun 17, 2022
keithmattix
approved these changes
Jun 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarah Christoff [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the [osm-docs] (https://github.com/openservicemesh/osm-docs) repo (if applicable)? No