This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Set (empty) trust domain on listener builder #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steeling
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
steeling
force-pushed
the
feature/set-principal
branch
2 times, most recently
from
4d60657 to
dc08728
Compare
|
Is this different from #4782? The names are very similar |
steeling
changed the title
oops didn't realize that, yes they're different; fixed names now |
nojnhuh
approved these changes
Jun 9, 2022
1. Change the policy builder's AddPrincipal, to AddIdentity so that the builder accepts OSM constructs as inputs, and returns envoy constructs. 2. Set the trust domain (currently an empty string) on the listener builder so that it will be used in the future. Part of openservicemesh#4754 Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/set-principal
branch
from
dc08728 to
8e7b28b
Compare
Codecov Report
@@ Coverage Diff @@
## main #4802 +/- ##
==========================================
- Coverage 68.62% 68.56% -0.07%
==========================================
Files 223 223
Lines 16265 16233 -32
==========================================
- Hits 11162 11130 -32
Misses 5052 5052
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
reviewed
Jun 9, 2022
jaellio
approved these changes
Jun 9, 2022
shashankram
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 main changes:
The final PR will be to simultaneously remove the trustDomain from service.Identity, while populating the trust domain within the cert manager.