This repository was archived by the owner on Jul 11, 2023. It is now read-only.
demo: Add scripts for Kafka demo #4770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Kafka to our existing Zookeeper demo script makes the demo more relevant to our customers as Zookeeper is rarely used as a standalone datastore. This allows us to integrate Kafka into our demo if we wish (e.g. send a message every time a book is purchased) Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
trstringer
suggested changes
May 27, 2022
Signed-off-by: Keith Mattix II <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4770 +/- ##
==========================================
+ Coverage 68.96% 69.06% +0.09%
==========================================
Files 227 225 -2
Lines 16454 16365 -89
==========================================
- Hits 11348 11302 -46
+ Misses 5054 5011 -43
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
reviewed
May 27, 2022
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
jaellio
reviewed
Jun 2, 2022
jaellio
approved these changes
Jun 2, 2022
trstringer
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Kafka to our existing Zookeeper demo script makes the
demo more relevant to our customers as Zookeeper is rarely used
as a standalone datastore. This allows us to integrate Kafka into
our demo if we wish (e.g. send a message every time a book is purchased)
Signed-off-by: Keith Mattix II [email protected]
Description:
Testing done:
N/A
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?