This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Backport: Add root path ingress e2e test (#4756) #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue where an ingress without a root path does not work for some non-kind distributions like AKS: kubernetes/ingress-nginx#8518. Adding a wildcard path in addition to the status/200 path resolves the issue. Signed-off-by: nshankar13 <[email protected]>
nshankar13
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
nojnhuh
approved these changes
May 25, 2022
jaellio
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where an ingress without a root path does
not work for some non-kind distributions like AKS:
kubernetes/ingress-nginx#8518.
Adding a wildcard path in addition to the status/200 path resolves
the issue.
Signed-off-by: nshankar13 [email protected]
Description: Cherry pick commit to add wildcard path to ingress in ingress backend e2e.
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?