This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Certificate issuance state management #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steeling
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
|
@steeling could you please update the PR description to elaborate on the changes made in this PR? |
jaellio
reviewed
May 13, 2022
jaellio
reviewed
May 13, 2022
30 tasks
Codecov Report
@@ Coverage Diff @@
## main #4743 +/- ##
==========================================
+ Coverage 68.85% 68.97% +0.11%
==========================================
Files 227 227
Lines 16170 16192 +22
==========================================
+ Hits 11134 11168 +34
+ Misses 4984 4972 -12
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
steeling
force-pushed
the
featurt/next-up
branch
2 times, most recently
from
6f22f45 to
70c8651
Compare
Enable the certificate handler to correctly issue certificates from the correct issuer based on the set state. We don't actually populate any additional states yet. Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
jaellio
reviewed
May 18, 2022
jaellio
reviewed
May 18, 2022
jaellio
approved these changes
May 18, 2022
Signed-off-by: Sean Teeling <[email protected]>
|
@nojnhuh @shashankram @trstringer friendly ping on this |
shashankram
approved these changes
May 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State management for certificate rotation
This PR implements certificate state management for rotation, by maintaining 2
certificate.Issuer's (previouslycertificate.Provider). It adds an ID to each issuer, to be extracted from the MRC, to delineate between a prior issued cert, and the current intended issuer.We then add a combine method on a certificate, which will add in a
pem.RootCertificate, such thatGetIssuingCAwill now return the combined set of certificates for validation.