This repository was archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
docs(contrib): add security.md #4722
Merged
shashankram
merged 3 commits into
openservicemesh:main
from
schristoff:schristoff_iss2402
Jun 8, 2022
Merged
docs(contrib): add security.md #4722
shashankram
merged 3 commits into
openservicemesh:main
from
schristoff:schristoff_iss2402
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Christoff <[email protected]>
@schristoff could you please add a commit message or PR description to this PR? Thanks! |
shashankram
suggested changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good start. Suggested a few changes.
allenlsy
reviewed
May 12, 2022
Signed-off-by: Sarah Christoff <[email protected]>
shashankram
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schristoff!
@phillipgibson Would you mind taking a look at this? |
A good start. I would also take a look at Helm's guide as well. I think we should have the sections on when and when not to send a report so there's clarity. |
Signed-off-by: Sarah Christoff <[email protected]>
@phillipgibson let me know if these new sections are what you were thinking |
phillipgibson
approved these changes
Jun 8, 2022
@trstringer could you review this? |
trstringer
approved these changes
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarah Christoff [email protected]
Description:
Fixes #2402
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
yes
Is this a breaking change?
no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
n/a