Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

docs(contrib): add security.md #4722

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

schristoff
Copy link
Contributor

@schristoff schristoff commented May 4, 2022

Signed-off-by: Sarah Christoff [email protected]

Description:
Fixes #2402

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
      yes
  2. Is this a breaking change?
    no

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
    n/a

Signed-off-by: Sarah Christoff <[email protected]>
@jaellio
Copy link
Contributor

jaellio commented May 5, 2022

@schristoff could you please add a commit message or PR description to this PR? Thanks!

Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start. Suggested a few changes.

Signed-off-by: Sarah Christoff <[email protected]>
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schristoff!

@nojnhuh
Copy link
Contributor

nojnhuh commented May 23, 2022

@phillipgibson Would you mind taking a look at this?

@phillipgibson
Copy link
Contributor

A good start. I would also take a look at Helm's guide as well. I think we should have the sections on when and when not to send a report so there's clarity.

@schristoff
Copy link
Contributor Author

@phillipgibson let me know if these new sections are what you were thinking

@shashankram
Copy link
Member

@trstringer could you review this?

@shashankram shashankram added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@shashankram shashankram removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@shashankram shashankram merged commit 0ba8d42 into openservicemesh:main Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create security issue reporting process and add SECURITY.md file
7 participants