This repository was archived by the owner on Jul 11, 2023. It is now read-only.
apis: add MeshRootCertificate API types #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steeling
approved these changes
Apr 21, 2022
Adds the Go types for the MeshRootCertificate API Part of openservicemesh#4502 Signed-off-by: jaellio <[email protected]>
jaellio
force-pushed
the
meshRootCertAPI
branch
from
66643c4 to
093f6a0
Compare
jaellio
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
trstringer
as code owners
shashankram
suggested changes
Apr 22, 2022
| type MeshRootCertificateSpec struct { | ||
| // Provider specifies the mesh certificate provider | ||
| // +optional | ||
| Provider *ProviderSpec `json:"provider,omitempty"` |
There was a problem hiding this comment.
Is there a reason the only field in the spec is optional? Does an empty spec mean something?
Signed-off-by: jaellio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
- Coverage 69.76% 69.47% -0.30%
==========================================
Files 217 217
Lines 15020 15325 +305
==========================================
+ Hits 10479 10647 +168
- Misses 4491 4628 +137
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: jaellio <[email protected]>
shashankram
approved these changes
Apr 22, 2022
nojnhuh
approved these changes
Apr 22, 2022
30 tasks
keithmattix
pushed a commit
to keithmattix/osm
that referenced
this pull request
May 3, 2022
* apis: add MeshRootCertificate API types Adds the Go types for the MeshRootCertificate API Part of openservicemesh#4502 Signed-off-by: jaellio <[email protected]> * Use v1alpha2 Signed-off-by: jaellio <[email protected]> * Update ProviderSpec Signed-off-by: jaellio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the Go types for the MeshRootCertificate API
Part of #4502
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?