This repository was archived by the owner on Jul 11, 2023. It is now read-only.
catalog/ingress: check backend's port in addition to name #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that the IngressBackend's port matches the TargetPort of the service. This is important in deployments where there are multiple MeshServices with the same name, in which case the IngressBackend configuration corresponding to the service name and port must be used. Multiple MeshService objects with the same name and different port number will exist when there is a k8s service with multiple ports per service. Without this change, IngressBackend configuration for a service with multiple ports can result in conflicts where duplicate configs are generated per MeshService. Signed-off-by: Shashank Ram <[email protected]>
draychev
approved these changes
Sep 30, 2021
snehachhabria
approved these changes
Oct 1, 2021
shashankram
added a commit
to shashankram/osm
that referenced
this pull request
Oct 1, 2021
…emesh#4202) Checks that the IngressBackend's port matches the TargetPort of the service. This is important in deployments where there are multiple MeshServices with the same name, in which case the IngressBackend configuration corresponding to the service name and port must be used. Multiple MeshService objects with the same name and different port number will exist when there is a k8s service with multiple ports per service. Without this change, IngressBackend configuration for a service with multiple ports can result in conflicts where duplicate configs are generated per MeshService. Signed-off-by: Shashank Ram <[email protected]>
shashankram
added a commit
that referenced
this pull request
Oct 1, 2021
[backport] catalog/ingress: check backend's port in addition to name (#4202)
|
Backport to v0.11 is done. |
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
…emesh#4202) Checks that the IngressBackend's port matches the TargetPort of the service. This is important in deployments where there are multiple MeshServices with the same name, in which case the IngressBackend configuration corresponding to the service name and port must be used. Multiple MeshService objects with the same name and different port number will exist when there is a k8s service with multiple ports per service. Without this change, IngressBackend configuration for a service with multiple ports can result in conflicts where duplicate configs are generated per MeshService. Signed-off-by: Shashank Ram <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
…emesh#4202) Checks that the IngressBackend's port matches the TargetPort of the service. This is important in deployments where there are multiple MeshServices with the same name, in which case the IngressBackend configuration corresponding to the service name and port must be used. Multiple MeshService objects with the same name and different port number will exist when there is a k8s service with multiple ports per service. Without this change, IngressBackend configuration for a service with multiple ports can result in conflicts where duplicate configs are generated per MeshService. Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checks that the IngressBackend's port matches the TargetPort
of the service. This is important in deployments where there
are multiple MeshServices with the same name, in which case
the IngressBackend configuration corresponding to the service
name and port must be used. Multiple MeshService objects with
the same name and different port number will exist when there
is a k8s service with multiple ports per service.
Without this change, IngressBackend configuration for a service
with multiple ports can result in conflicts where duplicate
configs are generated per MeshService.
Testing done:
Tested IngressBackend with multiple port per service.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no