This repository was archived by the owner on Jul 11, 2023. It is now read-only.
chore(demo): Add CTR_REGISTRY_CREDS_NAME to mysql demo container #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to run the demo with a private registry Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
cc @allenlsy |
Codecov Report
@@ Coverage Diff @@
## main #4186 +/- ##
==========================================
- Coverage 69.84% 69.81% -0.03%
==========================================
Files 212 212
Lines 11618 11620 +2
==========================================
- Hits 8115 8113 -2
- Misses 3451 3455 +4
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
draychev
approved these changes
Sep 29, 2021
trstringer
approved these changes
Sep 29, 2021
|
btw I don't have permissions to merge so a maintainer will need to do that. |
allenlsy
reviewed
Oct 8, 2021
| @@ -70,6 +70,8 @@ spec: | |||
| volumes: | |||
| - name: data | |||
| emptyDir: {} | |||
| imagePullSecrets: | |||
| - name: $CTR_REGISTRY_CREDS_NAME | |||
There was a problem hiding this comment.
Note that in .env.example, CTR_REGISTRY_CREDS_NAME is optional. We need to ensure it is defined.
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
…nservicemesh#4186) Allows users to run the demo with a private registry Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
…nservicemesh#4186) Allows users to run the demo with a private registry Signed-off-by: Sotiris Nanopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to run the demo with a private registry
Signed-off-by: Sotiris Nanopoulos [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?