test(osm-bootstrap): add unit tests for mesh config #4181
Conversation
| "envoyImage": "envoyproxy/envoy-alpine@sha256:6502a637c6c5fba4d03d0672d878d12da4bcc7a0d0fb3f1d506982dde0039abd", | ||
| "initContainerImage": "openservicemesh/init:latest-main", | ||
| "configResyncInterval": "2s" | ||
| "enablePrivilegedInitContainer": false, |
There was a problem hiding this comment.
didn't impact tests but I added back the indentation for readability. thanks for noticing.
michelleN
force-pushed
the
bootstrap
branch
from
769200c to
db7181d
Compare
Codecov Report
@@ Coverage Diff @@
## main #4181 +/- ##
==========================================
+ Coverage 69.91% 69.99% +0.07%
==========================================
Files 212 212
Lines 11615 11630 +15
==========================================
+ Hits 8121 8140 +19
+ Misses 3441 3437 -4
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| if apierrors.IsAlreadyExists(err) { | ||
| return nil |
There was a problem hiding this comment.
it would be nice if we could keep the logs that were present previously
There was a problem hiding this comment.
I just bubbled up the error to main() where there is one log line which wraps the error https://github.com/openservicemesh/osm/pull/4181/files#diff-2aa329ee12aeb0b3d3a60599559a0bbe07422779d9f730f4be4e668b275e06acR146
I thought a log line here might be confusing but I can add it in.
+ adds unit tests for mesh config logic Signed-off-by: Michelle Noorali <[email protected]>
michelleN
force-pushed
the
bootstrap
branch
from
db7181d to
5a5214a
Compare
…4181) + adds unit tests for mesh config logic Signed-off-by: Michelle Noorali <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
…4181) + adds unit tests for mesh config logic Signed-off-by: Michelle Noorali <[email protected]>
Signed-off-by: Michelle Noorali [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?