Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

CI/test: add race detection check #4157

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

shashankram
Copy link
Member

Description:
Adds race detection for Go unit tests.

Affected area:

Functional Area
Tests [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Adds race detection for Go unit tests.

Signed-off-by: Shashank Ram <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4157 (0aa8180) into main (2d2be96) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
- Coverage   69.81%   69.78%   -0.04%     
==========================================
  Files         211      211              
  Lines       11463    11463              
==========================================
- Hits         8003     7999       -4     
- Misses       3407     3411       +4     
  Partials       53       53              
Flag Coverage Δ
unittests 69.78% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crdconversion/crdconversion.go 71.42% <0.00%> (-4.09%) ⬇️
pkg/certificate/rotor/rotor.go 84.37% <0.00%> (-3.13%) ⬇️
pkg/providers/kube/client.go 71.68% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2be96...0aa8180. Read the comment docs.

@shashankram shashankram marked this pull request as ready for review September 22, 2021 20:58
@shashankram shashankram requested a review from a team as a code owner September 22, 2021 20:58
@shashankram shashankram merged commit 6f5f2bb into openservicemesh:main Sep 22, 2021
@shashankram shashankram deleted the gotest branch September 22, 2021 22:47
snehachhabria pushed a commit to snehachhabria/osm that referenced this pull request Oct 14, 2021
Adds race detection for Go unit tests.

Signed-off-by: Shashank Ram <[email protected]>
Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants